Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POLIO-1662 Supply Chain: VRF & DG Approval include options of 'missing' and 'not required' #1638

Conversation

mathvdh
Copy link
Collaborator

@mathvdh mathvdh commented Sep 17, 2024

Supply Chain: VRF & DG Approval include options of 'missing' and 'not required'

Related JIRA tickets : POLIO-1662

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests

Changes

  • Add a “type” on the VRF model with default “Normal”, with other options “Missing” and “Not Required”.
  • When its Not Required, the optional fields of the VRF will be hidden, as well as the the Pre Alerts and VAR tabs.
  • Field Quantity Ordered In Doses must become optional (Default to 0)

How to test

See video below, but basically go to Vaccine Supply Chain and create a new entry or edit an existing entry and try to play with the VRF Type field

Print screen / video

Screen.Recording.2024-09-18.at.14.13.54.mov

@mathvdh mathvdh marked this pull request as ready for review September 18, 2024 13:17
@beygorghor beygorghor added the release Should be released in production at next deploy label Sep 19, 2024
@tdethier tdethier self-requested a review September 20, 2024 08:04
Copy link
Member

@tdethier tdethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I didn't understand the context of all of this, so I just looked at the code and tested the feature.)

I managed to update existing data and to change the VRF type.
But I tried to create new data with VRF type Missing or Not Required and I couldn't do it, because the save button is disabled on both cases. Is this a bug or done on purpose @mathvdh?

image

@mathvdh
Copy link
Collaborator Author

mathvdh commented Sep 20, 2024

@tdethier it's not normal, I'll have a look into it, thanks

Copy link
Member

@tdethier tdethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mathvdh mathvdh merged commit 6879958 into main Sep 23, 2024
3 checks passed
@mathvdh mathvdh deleted the POLIO-1662-supply-chain-vrf-dg-approval-include-options-of-missing-and-not-required branch September 23, 2024 16:43
@mathvdh mathvdh mentioned this pull request Sep 23, 2024
7 tasks
@kemar kemar removed the release Should be released in production at next deploy label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants