-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POLIO-1662 Supply Chain: VRF & DG Approval include options of 'missing' and 'not required' #1638
POLIO-1662 Supply Chain: VRF & DG Approval include options of 'missing' and 'not required' #1638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I didn't understand the context of all of this, so I just looked at the code and tested the feature.)
I managed to update existing data and to change the VRF type.
But I tried to create new data with VRF type Missing
or Not Required
and I couldn't do it, because the save button is disabled on both cases. Is this a bug or done on purpose @mathvdh?
@tdethier it's not normal, I'll have a look into it, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Supply Chain: VRF & DG Approval include options of 'missing' and 'not required'
Related JIRA tickets : POLIO-1662
Self proofreading checklist
Changes
How to test
See video below, but basically go to Vaccine Supply Chain and create a new entry or edit an existing entry and try to play with the VRF Type field
Print screen / video
Screen.Recording.2024-09-18.at.14.13.54.mov