-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IA-3364 user history front end #1615
Conversation
…LSQ/iaso into IA-3364_user_history_front-end
- fix default pageSize - remove sort on columns with list values
- Add UserHistoryLogDetails, UserLogCompare, UserLogValueWithErrorBoundary, UserLogValue - All are derived from the existing Log components which are specific to org units and repurposed for users - Add translations
- Update WarningModal o make it reusable - Add WarningModal if user updates existing phone number
- handle all warning cases in one modal
…g_when_updating_phone_number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
you need to invalid logs while updating a user profile, i had to refresh logs to see changes
https://github.com/user-attachments/assets/72d17b70-300b-4414-bc8f-37b555f64ed8 -
While on a user management or history, this is not reflected in the side menu
Uploading Screen Recording 2024-09-11 at 13.23.45.mov… -
introducing a wrong phone number should show an error above the field
Showing errors in phone number field is a bit out of scope for this PR in my opinion. Anyway, it would require using the exact same validation list as the backend. I didn't use it in the |
- update menu and base urtl to highlight current menu location - update related test plus a hardcoded url in WFP - invalidate usersHistoryList queryKey when saving a user
…g_when_updating_phone_number
- don't show password updated unless it's True
…phone_number IA-3398 add warning when updating phone number
Explain what problem this PR is resolving
Related JIRA tickets : IA-3364
Self proofreading checklist
Doc
Changes
userlogs
apisubComponent
to expand the view under the current rowlogs
api to get dataHow to test
Go to users > history:
Print screen / video
Uploading Screen Recording 2024-09-09 at 17.08.00.mov…
Notes
Merges into #1614