Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA-3379: Allow the mobile app to download all groups #1592

Merged
merged 5 commits into from
Sep 5, 2024

Conversation

bmonjoie
Copy link
Member

This adds a query parameter showDeleted for the mobile app to download groups from all source_version.

Related JIRA tickets : IA-3379

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are there enough tests

Doc

  • In the code as swagger annotations

Changes

Allow to pass showDeleted=true to the endpoint to retrieve all source_versions, even the ones not used by the project.

How to test

Call the endpoint with and without the parameter showDeleted=true

This adds a query parameter `showDeleted` that allows the mobile app to download
groups from all source_version.

IA-3379
@bmonjoie bmonjoie added the enhancement New feature or request label Aug 28, 2024
@bmonjoie bmonjoie requested a review from kemar August 28, 2024 09:13
@bmonjoie bmonjoie self-assigned this Aug 28, 2024
@bmonjoie bmonjoie requested a review from tdethier August 28, 2024 09:13
Copy link
Member

@tdethier tdethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kemar
Copy link
Member

kemar commented Aug 28, 2024

I'm suggesting something here #1595 tell me what you think.

Copy link
Member

@kemar kemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beygorghor beygorghor added the release Should be released in production at next deploy label Sep 5, 2024
@beygorghor beygorghor merged commit e318502 into main Sep 5, 2024
3 checks passed
@beygorghor beygorghor deleted the feat/IA-3379_allow_mobile_to_download_all_groups branch September 5, 2024 08:03
@kemar kemar removed the release Should be released in production at next deploy label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants