Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent players from playing the game as invisible #129

Merged
merged 2 commits into from
Jul 14, 2024

Conversation

SpirTBBX
Copy link
Contributor

@SpirTBBX SpirTBBX commented Jul 11, 2024

This pull request addresses an issue where players can join as spectator and still act like they were playing in a team.

Any allocator would still provide weapons to the players and they would be able to not only have xray, but to also kill other players while being invisible. The bug would stop happening to that specific player once somebody else could kill that player. This glitch will happen when the player joins and, as I've seen, only happens when the map changes (in the warmup phase).

For that, I changed when we force the player team to address the issue. Changing the team on the 1 second timer is not a problem, as the player takes more than a second to change from the loading screen to the select team screen.

Hope this helps.

This commit has been properly tested and is currently being used in my production servers.

Best Regards,
SpirT

Copy link
Owner

@B3none B3none left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of changes to make, then it's good to merge.

RetakesPlugin/RetakesPlugin.cs Outdated Show resolved Hide resolved
@B3none B3none merged commit e2c5c3b into B3none:master Jul 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants