Remove player from game and queue if they are moved to spectator #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These changes look great, are you able to move this logic into the relevant manager, I think I have separate team management logic in one of those where this code should be. If it can’t go there and it must go here then we can, I would also like to add a config option to give people the choice for how they would like to handle this. Basically just put it in an if statement with a config variable check. |
|
Hope this resolves your comment, was unsure where to place the function but currently I put it in the GameManager class as it best fits there. |
B3none
requested changes
May 19, 2024
|
Bumped to 2.0.5 instead of 2.0.3 as we are on 2.0.4 |
B3none
requested changes
May 19, 2024
B3none
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made these changes to ensure it is compatible with a plugin such as AFKManager which only moves a player to spectator and has no way of knowing how to dequeue a player. Without this change players will be moved to spectator and then moved back into a team and actually never get kicked if you do not use an overly aggressive afk kick of 15 seconds without spectator. I made this for personal use but thought it might be benefit others