Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

Comment links should scroll down to the relevant comment #26

Open
goblindegook opened this issue Nov 1, 2014 · 2 comments
Open

Comment links should scroll down to the relevant comment #26

goblindegook opened this issue Nov 1, 2014 · 2 comments
Labels
bug
Milestone
1.0

Comments

@goblindegook
Copy link
Member

Links in the format http://local.wordpress.dev/{post}/#comment-{comment-id} don't work, the fragment is clearly confusing Backbone.
@goblindegook goblindegook added this to the 1.0 milestone Nov 1, 2014
@goblindegook
Copy link
Member Author

Should we register a new route for comments? Something like :post/comment/:comment?

If so, this endpoint should display the :post as normal, and scroll to the comment on load.

@goblindegook goblindegook assigned pcruz7 and unassigned pcruz7 Nov 1, 2014
@goblindegook
Copy link
Member Author

It was a routing issue.

However, it would be nice if the page scrolled down to the relevant comment ID.

@goblindegook goblindegook changed the title Comment links don't work Comment links should scroll down to the relevant comment Nov 2, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@goblindegook @pcruz7