Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure-core] discrepancies between azure and unbranded pageable #1963

Open
tadelesh opened this issue Dec 9, 2024 · 3 comments
Open

[azure-core] discrepancies between azure and unbranded pageable #1963

tadelesh opened this issue Dec 9, 2024 · 3 comments
Labels
feature New feature or request lib:azure-core Issues for @azure-tools/typespec-azure-core library
Milestone

Comments

@tadelesh
Copy link
Member

tadelesh commented Dec 9, 2024

in core, we have @pageItems to specify the the property that contains the array of page items. in azure core lib, we ahve @items to do the same thing. do we have plan to consolidate them?

@tadelesh tadelesh added the lib:azure-core Issues for @azure-tools/typespec-azure-core library label Dec 9, 2024
@markcowl markcowl added the feature New feature or request label Dec 9, 2024
@markcowl markcowl added this to the Backlog milestone Dec 9, 2024
@tadelesh
Copy link
Member Author

tadelesh commented Dec 19, 2024

also there are discrepancies for indicating if the operation is pageable. in azure, we use @pagedResult, in unbranded, we use @list. also, unbranded will check if there is at least @pageItems, but azure does not do validation for @items.

@tadelesh tadelesh changed the title [azure-core] duplicate decorator with core for paging [azure-core] discrepancies between azure and unbranded list Dec 19, 2024
@tadelesh tadelesh changed the title [azure-core] discrepancies between azure and unbranded list [azure-core] discrepancies between azure and unbranded pageable Dec 19, 2024
@lmazuel
Copy link
Member

lmazuel commented Dec 19, 2024

@markcowl I think the nextLink simplification was a good step, but we need more consolidation :)

@qiaozha
Copy link
Member

qiaozha commented Dec 19, 2024

I feel like we should also leverage the @list decorator in azure scope? using @pagedResult on a model to detect if it's a paging operation might be problematic if this model is being used in a non paging operation or being used as a property type of a non paging operation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request lib:azure-core Issues for @azure-tools/typespec-azure-core library
Projects
None yet
Development

No branches or pull requests

4 participants