Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two resources with one properties flattens while the other not #1931

Open
Tracked by #1850
pshao25 opened this issue Nov 29, 2024 · 1 comment
Open
Tracked by #1850

Two resources with one properties flattens while the other not #1931

pshao25 opened this issue Nov 29, 2024 · 1 comment
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@pshao25
Copy link
Member

pshao25 commented Nov 29, 2024

HybridConnectivity has two resources:

  1. ServiceConfigurationResource with "x-ms-client-flatten": true.
  2. EndpointResource with "x-ms-client-flatten": false

How could we represent these two in same spec?

@markcowl markcowl added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label Dec 2, 2024
@markcowl
Copy link
Member

markcowl commented Dec 2, 2024

@pshao25 This feels like a tcgc issue. flattening is strictly client-specific and has no impact on the actual API. The agreement was for flattening to be enabled or disabled for a spec - since this only impacts clients, if more granular control over flattening is required, these seem to belong to client-side decoration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Development

No branches or pull requests

2 participants