It can deploy the illegal code via VSCode without validation error.

[nobuko-yamada]

Describe the Bug with repro steps

It isn't efficient.

For example, we can deploy the code unexpectedly like below including terminate action within ForEach.

Only after the opening from AzurePortal, we can find the validation error of the code.

What type of Logic App Is this happening in?

Standard (VSCode)

Which operating system are you using?

Windows

Are you using new designer or old designer

New Designer

Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg

Yes

Workflow JSON

{
    "definition": {
        "$schema": "https://schema.management.azure.com/providers/Microsoft.Logic/schemas/2016-06-01/workflowdefinition.json#",
        "actions": {
            "For_each": {
                "type": "Foreach",
                "foreach": "@range(0,3)",
                "actions": {
                    "Terminate": {
                        "type": "Terminate",
                        "inputs": {
                            "runStatus": "Failed",
                            "runError": {
                                "code": "9",
                                "message": "error"
                            }
                        }
                    }
                },
                "runAfter": {}
            }
        },
        "triggers": {
            "When_a_HTTP_request_is_received": {
                "type": "Request",
                "kind": "Http"
            }
        },
        "contentVersion": "1.0.0.0",
        "outputs": {},
        "parameters": {}
    },
    "kind": "Stateful"
}

Screenshots or Videos

No response

Browser

via VSCode.

Additional context

No response

[nobuko-yamada]

We can refer:
Do not allow to save if there are illegal steps on a workflow. · Issue Azure/LogicAppsUX#984 · Azure/logicapps (github.com)

[ccastrotrejo]

Hi @nobuko-yamada thanks for raising this isssue. I will take a look on how we can validate the workflow.json before deploying it

[ccastrotrejo]

Hi @nobuko-yamada I will make the update to validate the workflow definition while saving it when using the Designer locally and prior deploying it. I am working with the BE team right now to make the right changes for it. I will update the issue as soon as I have the fix

[nobuko-yamada]

[heart] Nobuko Yamada reacted to your message:

…

________________________________ From: Carlos Emiliano Castro Trejo ***@***.***> Sent: Tuesday, September 24, 2024 11:00:13 PM To: Azure/LogicAppsUX ***@***.***> Cc: Mention ***@***.***>; Author ***@***.***>; Comment ***@***.***> Subject: Re: [Azure/LogicAppsUX] It can deploy the illegal code via VSCode without validation error. (Issue Azure/logicapps#1224) Hi @nobuko-yamada<https://github.com/nobuko-yamada> I will make the update to validate the workflow definition while saving it when using the Designer locally and prior deploying it. I am working with the BE team right now to make the right changes for it. I will update the issue as soon as I have the fix — Reply to this email directly, view it on GitHub<#1224> or unsubscribe<https://github.com/notifications/unsubscribe-auth/A3NXCBFSI574NO5OOHXWHULZYHVH3BFKMF2HI4TJMJ2XIZLTSSBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVI2TGMBXGQ4TIMRVGKSG4YLNMWUWQYLTL5WGCYTFNSWHG5LCNJSWG5C7OR4XAZNMJFZXG5LFINXW23LFNZ2KM5DPOBUWG44TQKSHI6LQMWVHEZLQN5ZWS5DPOJ42K5TBNR2WLKJTHE4TMMJYHE4TTAVEOR4XAZNFNFZXG5LFUV3GC3DVMWVDENJSGM4TKMBQGQ3YFJDUPFYGLJLMMFRGK3FFOZQWY5LFVI2TGMBXGQ4TIMRVGKTXI4TJM5TWK4VGMNZGKYLUMU>. You are receiving this email because you were mentioned. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[github-actions]

This issue is stale because it has been open for 45 days with no activity.