From c05ffad30d7350b9ee1d49aac7a96251fddc9dfe Mon Sep 17 00:00:00 2001 From: Charlie McBride Date: Tue, 7 Nov 2023 16:48:29 -0800 Subject: [PATCH 1/2] change to have the ApprovalComment need to have been a success to trigger e2e suite --- .github/workflows/e2e-matrix-trigger.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e-matrix-trigger.yaml b/.github/workflows/e2e-matrix-trigger.yaml index d5ac2709d..093bb2e15 100644 --- a/.github/workflows/e2e-matrix-trigger.yaml +++ b/.github/workflows/e2e-matrix-trigger.yaml @@ -13,7 +13,7 @@ permissions: contents: read # This is required for actions/checkout jobs: e2e-matrix: - if: github.event_name != 'pull_request_review' || startsWith(github.event.review.body ,'/test') + if: (github.event_name != 'pull_request_review' && github.event_name != 'workflow_run') || (github.event_name != 'pull_request_review' && startsWith(github.event.review.body ,'/test')) || (github.event_name != 'workflow_run' && github.event.workflow_run.conclusion == 'success') uses: ./.github/workflows/e2e-matrix.yaml secrets: E2E_CLIENT_ID: ${{ secrets.E2E_CLIENT_ID }} From 511b6339ddf332301a0f2e872b0533e83a7b219a Mon Sep 17 00:00:00 2001 From: Charlie McBride Date: Tue, 7 Nov 2023 16:54:23 -0800 Subject: [PATCH 2/2] fix bool logic --- .github/workflows/e2e-matrix-trigger.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e-matrix-trigger.yaml b/.github/workflows/e2e-matrix-trigger.yaml index 093bb2e15..78c71451b 100644 --- a/.github/workflows/e2e-matrix-trigger.yaml +++ b/.github/workflows/e2e-matrix-trigger.yaml @@ -13,7 +13,7 @@ permissions: contents: read # This is required for actions/checkout jobs: e2e-matrix: - if: (github.event_name != 'pull_request_review' && github.event_name != 'workflow_run') || (github.event_name != 'pull_request_review' && startsWith(github.event.review.body ,'/test')) || (github.event_name != 'workflow_run' && github.event.workflow_run.conclusion == 'success') + if: (github.event_name != 'pull_request_review' && github.event_name != 'workflow_run') || (github.event_name == 'pull_request_review' && startsWith(github.event.review.body ,'/test')) || (github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success') uses: ./.github/workflows/e2e-matrix.yaml secrets: E2E_CLIENT_ID: ${{ secrets.E2E_CLIENT_ID }}