Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Service bus custom endpoint address #43555

Open
Anton0123 opened this issue Dec 23, 2024 · 2 comments
Open

[BUG] Service bus custom endpoint address #43555

Anton0123 opened this issue Dec 23, 2024 · 2 comments
Labels
azure-spring All azure-spring related issues customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@Anton0123
Copy link

Anton0123 commented Dec 23, 2024

Describe the bug
The custom endpoint address is not merged from the namespace properties to producer/processor/consumer properties. This results in the custom endpoint address being null.

To Reproduce
Configure a custom endpoint address for the namespace but not for individual consumers or producers. The custom endpoint address will not be used when sending or receiving messages.

Code Snippet
Example configuration

spring:
  cloud:
    function:
      definition: consume;supply
    stream:
      bindings:
        consume-in-0:
          destination: sbq-test-1
        supply-out-0:
          destination: sbq-test-2
      binders:
        servicebus-0:
          type: servicebus
          default-candidate: true
          environment:
            spring:
              cloud:
                azure:
                  client:
                    amqp:
                      transport-type: amqp_web_sockets
                  servicebus:
                    custom-endpoint-address: https://test.address.com:443
                    namespace: sb-test-1
                    credential:
                      client-id: ${CLIENT_ID}
                      client-secret: ${CLIENT_SECRET}
                    profile:
                      tenant-id: ${TENANT_ID}
      servicebus:
        bindings:
          consume-in-0:
            consumer:
              entity-type: queue
          supply-out-0:
            producer:
              entity-type: queue

Expected behavior
I expect the custom-endpoint-address to be used by the consumers/producers/processors.

Screenshots
Image

Setup (please complete the following information):

  • OS: Windows 11
  • IDE: IntelliJ
  • Library/Libraries: com.azure.spring:spring-cloud-azure-stream-binder-servicebus:5.19.0
  • Java version: 22
  • App Server/Environment: -
  • Frameworks: Spring boot

Additional context
See com.azure.spring.messaging.servicebus.implementation.properties.merger, for example SenderPropertiesParentMerger. It does not map the custom endpoint address.
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/spring/spring-messaging-azure-servicebus/src/main/java/com/azure/spring/messaging/servicebus/implementation/properties/merger/SenderPropertiesParentMerger.java

@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Dec 23, 2024
@jairmyree jairmyree added the azure-spring All azure-spring related issues label Dec 31, 2024
@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 31, 2024
@jairmyree
Copy link
Member

@Anton0123 Thank you for reaching out. @Netyyyy could you please look into this issue?

@Netyyyy
Copy link
Member

Netyyyy commented Jan 3, 2025

Sure, we will take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
Status: Todo
Development

No branches or pull requests

3 participants