Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Publish to Java Dev Feed #43520

Merged

Conversation

alzimmermsft
Copy link
Member

Description

Fixes a bug that broke Publish to Java Dev Feed.

This issue arose due to a loose usage of /eng/versioning/external_dependencies.txt to resolve the version of maven-gpg-plugin. This change hardcodes the version of maven-gpg-plugin in the Publish-MavenPackages.ps1 script as it is an extremely unique usage of a dependency and should be treated differently than our other external dependencies. Doing this prevents conflicts with cleanup scripts that won't know about this usage and prevents cases where this could have been broken by accidental version changes that wouldn't be noticed in the PR as this logic is only invoked during release.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link
Member

@samvaity samvaity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will just have to keep updating it as it won't be read from the dependencies file anymore.

@alzimmermsft
Copy link
Member Author

/check-enforcer override

@alzimmermsft alzimmermsft merged commit 3de165d into Azure:main Dec 20, 2024
12 checks passed
@alzimmermsft alzimmermsft deleted the AzEng_FixFailingPublishToJavaDevFeed branch December 20, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants