-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClientCore tracing zero dependencies, no plugins #43346
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdk/clientcore/core/src/main/java/io/clientcore/core/observability/AttributeType.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/observability/AttributeKey.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/observability/AttributeKey.java
Outdated
Show resolved
Hide resolved
billwert
reviewed
Dec 12, 2024
sdk/clientcore/core/src/main/java/io/clientcore/core/http/pipeline/InstrumentationPolicy.java
Outdated
Show resolved
Hide resolved
lmolkova
changed the title
PoC: Clientcore tracing zero dependencies, no plugins
ClientCore tracing zero dependencies, no plugins
Dec 27, 2024
lmolkova
requested review from
mssfang,
JonathanGiles,
srnagar,
rujche,
Netyyyy,
saragluna,
moarychan,
samvaity and
vcolin7
as code owners
December 27, 2024 00:20
lmolkova
commented
Dec 29, 2024
lmolkova
commented
Dec 30, 2024
...core/src/main/java/io/clientcore/core/implementation/telemetry/otel/tracing/OTelContext.java
Outdated
Show resolved
Hide resolved
lmolkova
requested review from
joshfree,
anuchandy and
conniey
as code owners
December 31, 2024 02:40
lmolkova
force-pushed
the
client-core-tracing-shim
branch
from
December 31, 2024 04:17
43819a6
to
8c180cc
Compare
/azp run java - clientcore |
Azure Pipelines successfully started running 1 pipeline(s). |
API change check APIView has identified API level changes in this PR and created following API reviews. |
lmolkova
requested review from
hallipr,
weshaggard,
benbp and
JimSuplizio
as code owners
December 31, 2024 04:41
alzimmermsft
reviewed
Jan 3, 2025
sdk/clientcore/core/src/main/java/io/clientcore/core/http/pipeline/InstrumentationPolicy.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/http/pipeline/InstrumentationPolicy.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/http/pipeline/InstrumentationPolicy.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/http/pipeline/InstrumentationPolicy.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/http/pipeline/InstrumentationPolicy.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/implementation/UrlRedactionUtil.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/io/clientcore/core/implementation/instrumentation/otel/FallbackInvoker.java
Show resolved
Hide resolved
...e/src/main/java/io/clientcore/core/implementation/instrumentation/otel/OTelAttributeKey.java
Show resolved
Hide resolved
...rc/main/java/io/clientcore/core/implementation/instrumentation/otel/OTelInstrumentation.java
Outdated
Show resolved
Hide resolved
lmolkova
force-pushed
the
client-core-tracing-shim
branch
from
January 7, 2025 00:04
46f32b3
to
5c170ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is
an early prototype of possibletracing implementation in clientcore following slf4j shim philosophy:TODOs in this PR:
MethodHandle.invoke
agent and shading+relocation might need some additional tricks in reflection code, but seem doableTODO (follow up PRs):
HttpLogOptions
andTelemetryOptions
?HttpLoggingPolicy
andInstrumentationPolicy
?logging
totelemetry
packageMaven magic to compile with optional dependency on OTel, but not list it in the effective pomTODO later, when necessary: