KeyClient incorrectly sends explicit null value

[chlowell]

In the REST API spec, the "attributes" object of "KeyItem" isn't marked x-nullable, so a client shouldn't send an explicit null value for this key. KeyClient does, however, which gets an error response from Managed HSM.

repro

#include <azure/identity/azure_cli_credential.hpp>
#include <azure/keyvault/keys/key_client.hpp>
#include <azure/core/http/policies/policy.hpp>
#include <azure/core/http/http.hpp>
#include <iostream>
#include <memory>

class LoggingPolicy : public Azure::Core::Http::Policies::HttpPolicy
{
public:
    std::unique_ptr<Azure::Core::Http::RawResponse> Send(
        Azure::Core::Http::Request &request,
        Azure::Core::Http::Policies::NextHttpPolicy nextHttpPolicy,
        Azure::Core::Context const &context) const override
    {
        std::cout << request.GetMethod().ToString() << " " << request.GetUrl().GetPath() << std::endl;
        if (request.GetBodyStream())
        {
            auto bodyStream = request.GetBodyStream();
            std::vector<uint8_t> body(bodyStream->Length());
            bodyStream->Read(body.data(), body.size(), context);
            bodyStream->Rewind();
            std::cout << "\tBody: " << std::string(body.begin(), body.end()) << std::endl;
        }
        return nextHttpPolicy.Send(request, context);
    }

    std::unique_ptr<Azure::Core::Http::Policies::HttpPolicy> Clone() const override
    {
        return std::make_unique<LoggingPolicy>(*this);
    }
};

int main(int argc, char *argv[])
{
    std::string url = argv[1];

    auto credential = std::make_shared<Azure::Identity::AzureCliCredential>();

    auto opts = Azure::Security::KeyVault::Keys::KeyClientOptions();
    opts.PerRetryPolicies.emplace_back(std::make_unique<LoggingPolicy>());
    Azure::Security::KeyVault::Keys::KeyClient client(url, credential, opts);

    Azure::Security::KeyVault::Keys::CreateRsaKeyOptions createRsaKeyOptions("test-key", true);
    createRsaKeyOptions.KeySize = 2048;
    // uncommenting this enables the request to succeed
    // createRsaKeyOptions.Enabled = true;
    try
    {
        auto key = client.CreateRsaKey(createRsaKeyOptions).Value;
        std::cout << "Created key " << key.Id() << std::endl;
    }
    catch (Azure::Core::RequestFailedException const &e)
    {
        std::cerr << "Error: " << e.Message << std::endl;
    }

    return 0;
}

output

$ ./repro <MHSM URL>
POST /keys/test-key/create?api-version=7.3
        Body: {"attributes":null,"kty":"RSA-HSM"}
Error: Object Attributes: A JSON object was expected (Activity ID: ...)