You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
HttpRequest throws exception when the body is an IO object, because the code checks whether the body is an IO object but it actually uses the APIs of the File(derived from the IO object): body.size and body.path.
I am going to make a change to fix it. Here are some questions for discussion:
Shall we support File object only? Is it by-design?
Regarding API convenience, an IO or StringIO object may also be the body, shall we support it?
Using properties of File class with checks on IO class seems like a bug. I think we should support most possible scenarios for IO as you mentioned IO, File and StringIO as of now.
HttpRequest throws exception when the body is an
IO
object, because the code checks whether the body is anIO
object but it actually uses the APIs of theFile
(derived from theIO
object):body.size
andbody.path
.I am going to make a change to fix it. Here are some questions for discussion:
IO
orStringIO
object may also be the body, shall we support it?Thoughts? @vishrutshah , @veronicagg
The text was updated successfully, but these errors were encountered: