Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

shared_key.rb, storage, and tables in feature/arm #19

Open
veronicagg opened this issue Aug 15, 2016 · 4 comments
Open

shared_key.rb, storage, and tables in feature/arm #19

veronicagg opened this issue Aug 15, 2016 · 4 comments
Labels

Comments

@veronicagg
Copy link
Contributor

@djberg96 Moving issue Azure/azure-sdk-for-ruby#287 to asm-core repo:

I was just looking at: azure/lib/azure/core/auth/shared_key.rb

One issue I spotted is that it doesn't handle secondary accounts. The docs say "foo-secondary" should just be "foo" for the canonical name. This is just a matter of changing "account" to account.split("-").first.

But also, it looks like it always assumes file, glob and file services, based on the headers set in the signable_string method. It should be different for tables, right?

@yaxia
Copy link
Member

yaxia commented Aug 18, 2016

Regarding the shared_key.rb for the table service, there is a specific implementation. Please refer to: https://github.com/Azure/azure-storage-ruby/blob/master/lib/azure/storage/table/auth/shared_key.rb

@vishrutshah vishrutshah added the P2 label Nov 14, 2016
@vishrutshah vishrutshah added this to the ASM-Core Backlog milestone Nov 14, 2016
@djberg96
Copy link

@yaxia @veronicagg Is this issue addressed then?

@veronicagg
Copy link
Contributor Author

@yaxia have you looked into this further? otherwise, we haven't addressed the issue, and it was moved to "backlog". @yaxia if you believe this is not a problem anymore, please comment and close. thanks!

@yaxia
Copy link
Member

yaxia commented Aug 10, 2017

+@katmsft to take a look.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants