From a0ace9e8bb9e3fcb050d198718ce2a13197ea798 Mon Sep 17 00:00:00 2001 From: nikhilpadhye1 <68977752+nikhilpadhye1@users.noreply.github.com> Date: Fri, 21 Jun 2024 12:21:41 -0700 Subject: [PATCH] =?UTF-8?q?Moving=20missed=20changes=20from=202023-11-01?= =?UTF-8?q?=20packet=20capture=20swagger=20fix=20to=20l=E2=80=A6=20(#29473?= =?UTF-8?q?)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Adds base for updating Microsoft.Network from version stable/2023-11-01 to version 2024-01-01 * Updates readme * Updates API version in new specs and examples * Add examples for Subnet peering and v6 Subnet peering. (#28827) Add examples for Subnet peering and v6 Subnet peering. --------- Co-authored-by: saurabh83 * Init (#29127) Co-authored-by: Abhishek Shah * Adding the new response code to the 2024-01-01 version release of swagger to match the bugfix in 2023-11-01 (#29048) Co-authored-by: Arsheen Khatib (from Dev Box) * Added NoHealthyBackendsBehavior (#28868) Added the property "NoHealthyBackendsBehavior" to the Probe properties. * VirtualNetworkGatewayConnection using key vault for authentication. (#28760) * Add parameters for cert based auth connection * retrigger checks * retrigger checks * lintDiff * Trigger Build * revert PATCH changes * fix * change managed identity to v5 * add format and description * added networkidentifier under vnet->subet->serviceendpoint (#29292) * added networkidentifier under vnet->subet->serviceendpoint * resolving conflict (#29343) * Fix for PR VirtualNetworkGatewayConnection using key vault for authentication. (#29357) * Fix * Fix2 --------- Co-authored-by: Khushboo Baheti * Adding GET operaton for Network Virtual Appliance Inbound Secuirty Rule (#29339) * Moving missed changes from 2023-11-01 packet capture swagger fix to latest api version * Add CrossConnection Name as an optional query parameter in List ExpressRoute CrossConnection (#29251) * Add CrossConnection name as an optional query parameter for List CrossConnection * update example * Addressing comments * Change to OData filtering * Fix the parameter reference * Update --------- Co-authored-by: Jianqi Zhao * initial changes (#29235) * adding supression for the breaking change in azure-sdk-for-go * adding correct package for this supression --------- Co-authored-by: GuptaVertika <149072034+GuptaVertika@users.noreply.github.com> Co-authored-by: saurabh83 Co-authored-by: saurabh83 Co-authored-by: Abhishek Shah <16267081+abhi7860@users.noreply.github.com> Co-authored-by: Abhishek Shah Co-authored-by: AFK1194 Co-authored-by: Arsheen Khatib (from Dev Box) Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com> Co-authored-by: daweiwang-microsoft <165709729+daweiwang-microsoft@users.noreply.github.com> Co-authored-by: Bhupesh Kumar Bhatt <52891188+bhupeshbhatt1985@users.noreply.github.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com> Co-authored-by: jianzhao1992 <125631957+jianzhao1992@users.noreply.github.com> Co-authored-by: Jianqi Zhao Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com> --- .../stable/2024-01-01/azureFirewall.json | 20 +---- .../examples/AzureFirewallPacketCapture.json | 80 +++++++++---------- .../resource-manager/sdk-suppressions.yaml | 6 ++ 3 files changed, 47 insertions(+), 59 deletions(-) create mode 100644 specification/network/resource-manager/sdk-suppressions.yaml diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/azureFirewall.json b/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/azureFirewall.json index df777fa6ecc5..26de624c5689 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/azureFirewall.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/azureFirewall.json @@ -1217,7 +1217,7 @@ }, "description": "List of SNAT IP Prefixes learnt by firewall to not SNAT" }, - "FirewallPacketCaptureParametersFormat": { + "FirewallPacketCaptureParameters": { "type": "object", "properties": { "durationInSeconds": { @@ -1267,7 +1267,7 @@ "x-ms-identifiers": [] } }, - "description": "Packet capture parameters on azure firewall." + "description": "Azure Firewall Packet Capture Parameters." }, "AzureFirewallPacketCaptureFlags": { "type": "object", @@ -1321,22 +1321,6 @@ } }, "description": "Group of src/dest ips and ports to be captured." - }, - "FirewallPacketCaptureParameters": { - "type": "object", - "properties": { - "properties": { - "x-ms-client-flatten": true, - "$ref": "#/definitions/FirewallPacketCaptureParametersFormat", - "description": "Properties of the azure firewall." - } - }, - "allOf": [ - { - "$ref": "./network.json#/definitions/SubResource" - } - ], - "description": "Azure Firewall Packet Capture Parameters resource." } } } diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/examples/AzureFirewallPacketCapture.json b/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/examples/AzureFirewallPacketCapture.json index c9b956952b9b..ef6fa4397e1c 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/examples/AzureFirewallPacketCapture.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/examples/AzureFirewallPacketCapture.json @@ -5,47 +5,45 @@ "resourceGroupName": "rg1", "azureFirewallName": "azureFirewall1", "parameters": { - "properties": { - "durationInSeconds": 300, - "numberOfPacketsToCapture": 5000, - "sasUrl": "someSASURL", - "fileName": "azureFirewallPacketCapture", - "protocol": "Any", - "flags": [ - { - "type": "syn" - }, - { - "type": "fin" - } - ], - "filters": [ - { - "sources": [ - "20.1.1.0" - ], - "destinations": [ - "20.1.2.0" - ], - "destinationPorts": [ - "4500" - ] - }, - { - "sources": [ - "10.1.1.0", - "10.1.1.1" - ], - "destinations": [ - "10.1.2.0" - ], - "destinationPorts": [ - "123", - "80" - ] - } - ] - } + "durationInSeconds": 300, + "numberOfPacketsToCapture": 5000, + "sasUrl": "someSASURL", + "fileName": "azureFirewallPacketCapture", + "protocol": "Any", + "flags": [ + { + "type": "syn" + }, + { + "type": "fin" + } + ], + "filters": [ + { + "sources": [ + "20.1.1.0" + ], + "destinations": [ + "20.1.2.0" + ], + "destinationPorts": [ + "4500" + ] + }, + { + "sources": [ + "10.1.1.0", + "10.1.1.1" + ], + "destinations": [ + "10.1.2.0" + ], + "destinationPorts": [ + "123", + "80" + ] + } + ] } }, "responses": { diff --git a/specification/network/resource-manager/sdk-suppressions.yaml b/specification/network/resource-manager/sdk-suppressions.yaml new file mode 100644 index 000000000000..f5f18097c539 --- /dev/null +++ b/specification/network/resource-manager/sdk-suppressions.yaml @@ -0,0 +1,6 @@ +suppressions: + azure-sdk-for-go: + - package: 'sdk/resourcemanager/network/armnetwork' + breaking-changes: + - Struct `FirewallPacketCaptureParametersFormat` has been removed + - Field `ID`, `Properties` of struct `FirewallPacketCaptureParameters` has been removed \ No newline at end of file