Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeQL action and nightly runs to the public CI #1083

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

andystaples
Copy link
Contributor

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@andystaples andystaples requested a review from AnatoliB July 11, 2024 21:26
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@andystaples andystaples changed the title Add nightly runs to the public CI Add codeQL action and nightly runs to the public CI Oct 4, 2024
Copy link
Contributor

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at large

Comment on lines +9 to +11
branches: [ "dev", "*" ] # TODO: remove development branch after approval
pull_request:
branches: [ "dev", "*"] # TODO: remove development branch after approval
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not forget (like I did) to remove the TODO :)

@andystaples andystaples merged commit 7cb1b30 into dev Oct 4, 2024
2 of 6 checks passed
@andystaples andystaples deleted the andystaples/schedule-nightly-runs branch October 4, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants