Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Set-VirtualDesktopOptimizations.ps1 to reflect changes to VDOT Windows_VDOT.ps1 - Issue#706 #710

Closed
wants to merge 1 commit into from

Conversation

ThojoUno
Copy link

@ThojoUno ThojoUno commented Nov 6, 2024

Replace LGPO with LocalPolicy in Windows_VDOT-ps1 parameters

Current Set-VirtualDesktopOptimizations.ps1 will error out with message "The argument "LGPO" does not belong to the set". This is due to changes in Windows_VDOT.ps1, where LGPO has been replaced with the parameter "LocalPolicy"

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

Original line:
.\Windows_VDOT.ps1 -Optimizations 'AppxPackages','Autologgers','DefaultUserSettings','LGPO','NetworkOptimizations','ScheduledTasks','Services','WindowsMediaPlayer' -AdvancedOptimizations 'Edge','RemoveLegacyIE' -AcceptEULA -Verbose

Updated line:
.\Windows_VDOT.ps1 -Optimizations 'AppxPackages','Autologgers','DefaultUserSettings','LocalPolicy','NetworkOptimizations','ScheduledTasks','Services','WindowsMediaPlayer' -AdvancedOptimizations 'Edge','RemoveLegacyIE' -AcceptEULA -Verbose

Breaking Changes

None

Testing Evidence

Image template build state shows: Succeeded.

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (AVD LZA Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)

Replace LGPO with LocalPolicy in Windows_VDOT-ps1 parameters
@danycontre
Copy link
Collaborator

@ThojoUno thank you for your contribution, we have decided to remove VDOT functionality from the code given the variability of what customers could want to be part of the image.

@swathibhat1

@danycontre danycontre closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants