-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] SQL AVM Flagging false positives #3146
Comments
Thanks for reporting the issue @riosengineer. |
@riosengineer For For |
Thanks, I should have known about that as I already use it in my However, what is interesting is they aren't getting the alerts for the administratorLogin and administratorPassword as I notice they are running tests against a file that explicitly states those two params: https://github.com/Azure/bicep-registry-modules/blob/main/avm/res/sql/server/tests/e2e/defaults/main.test.bicep. I did some more testing and found even explicitly stating the two params, PSRule returns the rule back twice? Almost like it's expecting this in the main.bicep
main.bicepparam
And noticed the rule returns it twice. The param is not required but I wonder if the object
|
Existing rule
No response
Description of the issue
Hey @BernieWhite - hope you're well.
I am triggering these following rules:
Running:
PSRule v2.9.0 PSRule.Rules.Azure v1.38.0
When I am deploying the latest AVM for Azure SQL PaaS. I am actually passing an Entra security group for the login username and even with the
()secure
param on this it still flags. I thought it would remove the alert by doing that to bypass it but no luck. I think this may be related or the same as: #2813 ?I am also getting a keys flag when I'm not using keys. I feel it is expanding the source module of the AVM SQL and maybe there is an issue from that.
I know it's the AVM SQL because if I remove the module from my template, both these flags are not present. The source code is here: https://github.com/Azure/bicep-registry-modules/blob/main/avm/res/sql/server/main.bicep
Running the latest
Is this a potential bug? Thanks
Error messages
No response
Reproduction
Relevant code context to repro:
Param:
Template:
Version of PSRule
2.9.0
Version of PSRule for Azure
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: