Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure.AppService.UseHTTPS reports fail although app service is deployed with https only #1919

Open
MarcelHeek opened this issue Nov 30, 2022 · 9 comments
Labels
bug Something isn't working integration: azgovviz Issues related to integration with AzGovViz rule: app-service Rules for App Service

Comments

@MarcelHeek
Copy link

Description of the issue

We have (via IaC) deployed app services with the property 'https_only = true' in Terraform F CAF code.
When reviewing the deployed resource in the Azure portal is is actually set to HTTP Only, as can be seen in the screenshot
image

We see the same incorrect PSRule results on multiple app services deployed with similar code and with the HTTPS Only property set.

Steps to reproduce the issue:

Expected behaviour

I would expect that app service resources with HTTPS only would flag as passed instead of failed.

Error output


Module in use and version:

  • Module: PSRule.Rules.Azure
  • Version: 1.21.2

Captured output from $PSVersionTable:


Additional context

@MarcelHeek MarcelHeek added the bug Something isn't working label Nov 30, 2022
@BernieWhite BernieWhite added the rule: app-service Rules for App Service label Nov 30, 2022
@BernieWhite
Copy link
Collaborator

@MarcelHeek Thanks for reporting the issue.

Is this false positive being reported from AzGovViz or from the in-flight process mentioned here https://azure.github.io/PSRule.Rules.Azure/export-rule-data/?

@MarcelHeek
Copy link
Author

MarcelHeek commented Nov 30, 2022

@BernieWhite , I am actually reviewing the AzGovViz output, so yes, from AzGovViz.

@BernieWhite BernieWhite added the integration: azgovviz Issues related to integration with AzGovViz label Nov 30, 2022
@MarcelHeek
Copy link
Author

@BernieWhite I am actually also getting false-positives from the rule Azure.Storage.MinTLS

So is this an integration issue with the AzGovViz tool, right ? Should I also raise issue here : https://github.com/JulianHayward/Azure-MG-Sub-Governance-Reporting ?

@BernieWhite
Copy link
Collaborator

BernieWhite commented Nov 30, 2022

@MarcelHeek Just investigating it, but I think the properties of each resource is not being exported so the data being exported is not complete.

We have a similar issue with #1914.

@JulianHayward
Copy link

@MarcelHeek please test with fix branch

@MarcelHeek
Copy link
Author

@JulianHayward Is this fix branch already merged in v6_major_20221204_1 release, by any chance? Gues so, so I will give that one a go.

@BernieWhite
Copy link
Collaborator

@MarcelHeek Please let us know if that fixes the problem. Thanks @JulianHayward.

@MarcelHeek
Copy link
Author

MarcelHeek commented Dec 5, 2022

@BernieWhite @JulianHayward

I still get FAIL results for a simple WebApp.

First proof of new version being used:
image

The results as obtained from the PSRule csv output generated by the AzGovViz tool:
image

And the actual configuration in the Azure portal:
image

Last Friday I looked into a manual run of the PSRule.Rules.Azure module, and there (I only collected the FAIL results) the webapp was not in the list for this rule violation.

If any additional information is needed, please let me know.

@JulianHayward
Copy link

FYI: evaluating how to handle resources with child resources in the AzGovViz integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working integration: azgovviz Issues related to integration with AzGovViz rule: app-service Rules for App Service
Projects
None yet
Development

No branches or pull requests

3 participants