Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code extension makes use of user settings to write workspace settings #5892

Open
mindingdata opened this issue Oct 16, 2024 · 0 comments
Open
Assignees
Labels

Comments

@mindingdata
Copy link

mindingdata commented Oct 16, 2024

Describe the Bug with repro steps

I wrote down the majority of the issue over in the LogicApps repo here : Azure/logicapps#1183

But I noticed this has the actual code for the extension so I'll keep it short here.

  • In many cases, the Logic Apps (Standard) VS Code extension writes settings to the workspace settings file
  • Workspace settings are shared between developers and checked into source control (As opposed to User Settings for example)
  • The settings that are being written are specific to a user (e.g. File paths utilizing the User folder).

e.x.

"terminal.integrated.env.windows": {
      "PATH": "C:\\Users\\MyName\\.azurelogicapps\\dependencies\\DotNetSDK;${env:PATH}"
  }

I'm not familiar with VS Code extension but I can see this for example here :

await updateGlobalSetting(autoRuntimeDependenciesPathSettingKey, defaultDependencyPathValue);

Which then calls the UpdateGlobalSetting method here :

export async function updateGlobalSetting<T = string>(section: string, value: T, prefix: string = ext.prefix): Promise<void> {

This always updates the workspace settings. It would be much more helpful for these to be written to the user settings at the very least.

What type of Logic App Is this happening in?

Standard (VSCode)

Which operating system are you using?

Windows

Are you using new designer or old designer

New Designer

Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg

Yes

Workflow JSON

No response

Screenshots or Videos

No response

Browser

VS Code

Additional context

No response

@ccastrotrejo ccastrotrejo self-assigned this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants