Improved resource deletion actions/guidance

[blanquicet]

As a newcomer, after running ie execute [markdown file] --do-not-delete=false (the --do-not-delete flag could have been skipped as it is false by default), I was expecting that the Azure resources created by the scenario would have been deleted. However, it didn't happen because the markdown I used scenarios/ocd/CreateLinuxVMSecureWebServer/README.md doesn't contain the az group delete --name $MY_RESOURCE_GROUP_NAME command.

At this point, I would say that the --do-not-delete flag applies only if the the scenario contains the az group delete command, as confirmed by the comments:

InnovationEngine/internal/engine/execution.go

Lines 37 to 38 in 31f6ea5

	// If a scenario has an `az group delete` command and the `--do-not-delete`
	// flag is set, we remove it from the steps.

Therefore, I suggest to change the flag name from do-not-delete to skip-delete-cmds or skip-deletion or something similar. IMHO, that would make the flag usage clearer.

[rgardler-msft]

Changing the title of this to "Improved resource deletion actions/guidance" and upping the priority as this is a UX issue that is indeed confusing. We need to consider the behaviour of IE when there is a delete section in the document.

Initial thoughts on what we should do:

• in execute only output deletion instructions
• in test always delete resources upon success
• in learn mode ask the user if they want to delete
• in all cases if a deployment fails provide instructions (if not interactive) or ask whether they should be deleted (if interactive) - fixes (see Auto delete resources in error case in 'azure' environment #181 )