Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add evaluationDelay paramter for Deploy-Private-DNS-Generic policy #1650

Merged
merged 10 commits into from
May 28, 2024

Conversation

Springstone
Copy link
Member

@Springstone Springstone commented May 28, 2024

Overview/Summary

This pull request primarily introduces changes in the Deploy-Private-DNS-Generic policy and updates the Whats-new.md documentation accordingly. The main update is the addition of an evaluationDelay parameter to the policy, which allows for a delay in the evaluation of the policy. This change is reflected in both the policy definition and the policy rule.

Updates to Deploy-Private-DNS-Generic policy:

Documentation update:

  • docs/wiki/Whats-new.md: Updated the description of the Deploy-Private-DNS-Generic policy in the "This release includes:" section to include the new feature of supporting the configuration of the evaluation delay.

This PR fixes/adds/changes/removes

  1. Adding EvaluationDelay to Deploy-Private-DNS-Generic

Breaking Changes

  1. N/A

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

Testing URLs

Azure Public

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

This commit adds the functionality to evaluate the Deploy-Private-DNS-Generic policy immediately after successfully provisioning a resource, instead of waiting for the default 10 minutes. This change improves the efficiency of the policy evaluation process.
@Springstone Springstone changed the title feat: Add immediate evaluation for Deploy-Private-DNS-Generic policy feat: Add evaluationDelay paramter for Deploy-Private-DNS-Generic policy May 28, 2024
@Springstone Springstone requested a review from jtracey93 May 28, 2024 09:04
@Springstone Springstone added the Area: Policy 📝 Issues / PR's related to Policy label May 28, 2024
@Springstone Springstone requested a review from a team as a code owner May 28, 2024 09:16
@jtracey93 jtracey93 merged commit f4576ea into Azure:policy-refresh-q3fy24 May 28, 2024
3 of 4 checks passed
@Springstone Springstone deleted the pDNSupdate branch May 28, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Policy 📝 Issues / PR's related to Policy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants