-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add evaluationDelay paramter for Deploy-Private-DNS-Generic policy #1650
Merged
jtracey93
merged 10 commits into
Azure:policy-refresh-q3fy24
from
Springstone:pDNSupdate
May 28, 2024
Merged
feat: Add evaluationDelay paramter for Deploy-Private-DNS-Generic policy #1650
jtracey93
merged 10 commits into
Azure:policy-refresh-q3fy24
from
Springstone:pDNSupdate
May 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the functionality to evaluate the Deploy-Private-DNS-Generic policy immediately after successfully provisioning a resource, instead of waiting for the default 10 minutes. This change improves the efficiency of the policy evaluation process.
Springstone
changed the title
feat: Add immediate evaluation for Deploy-Private-DNS-Generic policy
feat: Add evaluationDelay paramter for Deploy-Private-DNS-Generic policy
May 28, 2024
jtracey93
requested changes
May 28, 2024
src/resources/Microsoft.Authorization/policyDefinitions/Deploy-Private-DNS-Generic.json
Outdated
Show resolved
Hide resolved
…-Private-DNS-Generic.json Co-authored-by: Jack Tracey <[email protected]>
jtracey93
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This pull request primarily introduces changes in the
Deploy-Private-DNS-Generic
policy and updates theWhats-new.md
documentation accordingly. The main update is the addition of anevaluationDelay
parameter to the policy, which allows for a delay in the evaluation of the policy. This change is reflected in both the policy definition and the policy rule.Updates to
Deploy-Private-DNS-Generic
policy:src/resources/Microsoft.Authorization/policyDefinitions/Deploy-Private-DNS-Generic.json
: Added a new parameterevaluationDelay
to the policy definition. This allows for a delay in the evaluation of the policy. The default value for this parameter is "PT10M".src/resources/Microsoft.Authorization/policyDefinitions/Deploy-Private-DNS-Generic.json
: Updated the policy rule to include theevaluationDelay
parameter.Documentation update:
docs/wiki/Whats-new.md
: Updated the description of theDeploy-Private-DNS-Generic
policy in the "This release includes:" section to include the new feature of supporting the configuration of the evaluation delay.This PR fixes/adds/changes/removes
Deploy-Private-DNS-Generic
Breaking Changes
Testing Evidence
Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
Testing URLs
Azure Public
As part of this Pull Request I have
main
branch/docs/wiki/whats-new.md
)