Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 Feature Request - Option/switch to bypass "resetting" APRL folder and git clone in 1_wara_collector.ps1 #111

Open
ehaslett opened this issue May 9, 2024 · 1 comment
Assignees
Labels
Area: Tools 🧰 Related to the tools directory and/or content Enhancement 🆕 New feature or request

Comments

@ehaslett
Copy link
Contributor

ehaslett commented May 9, 2024

Describe the solution you'd like

For customers that manually download the APRL repro because of firewall restrictions, an option to bypass the automatic git clone process in the LocalFiles function, so that it does not forcefully and recursively remove items in the clone path.

From customer feedback:

Include a switch parameter that allows bypass the “git” checks. Specifically in the LocalFiles function. The problem with the way it runs right now when you run the script if you have manually grabbed the required files/folders from git the script while running the checks in the LocalFiles function detects that the files/folder exists locally and it then says “resetting” it. It will try to use git to clone the repo from the git server. The problem is that the act of trying to clone from the server, even if its unable to reach the server, still clears , deletes the files you’ve copied manually.

In our environment we cannot directly clone from the git server (unless we’ve done all the magic to allow git client to go through the firewalls). So while playing with the script the localfiles check would end up killing the required files that the script uses for its checks so it fails to generate anything.

Describe alternatives you've considered

Customer implemented a work around by commenting out the code referened above in the LocalFiles function:

        #Get-Item -Path $Global:clonePath | Remove-Item -Recurse -Force
        #git clone $repoUrl $clonePath --quiet
      }
    else
      {
        #git clone $repoUrl $clonePath --quiet

Additional context

image

@oZakari oZakari added the Area: Tools 🧰 Related to the tools directory and/or content label May 13, 2024
@ejhenry ejhenry added the Enhancement 🆕 New feature or request label Jun 20, 2024
@ehaslett
Copy link
Contributor Author

As a lot has changed since this request, is this still a valid request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Tools 🧰 Related to the tools directory and/or content Enhancement 🆕 New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants