Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to add hostname binding for linkerd-viz #15

Open
razgrim opened this issue Nov 17, 2022 · 1 comment
Open

Need to add hostname binding for linkerd-viz #15

razgrim opened this issue Nov 17, 2022 · 1 comment

Comments

@razgrim
Copy link

razgrim commented Nov 17, 2022

We were trying to add an ingress for linkerd-viz, ran into an error which requires this
https://linkerd.io/2.12/tasks/exposing-dashboard/#tweaking-host-requirement

Basically we need this module to accept an optional URL pattern as a parameter, and plug it into a "enforcedHostRegexp " value inside https://github.com/Azure-Terraform/terraform-helm-linkerd/blob/main/templates/viz-ha.yaml
or
merge it in through https://github.com/Azure-Terraform/terraform-helm-linkerd/blob/main/locals.tf

We can make and PR this change, just putting in this issue to request access!

@ggolub
Copy link
Collaborator

ggolub commented Nov 18, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants