From 78f5a4178db8b8022c3c3ab92a31dd8571e75e2f Mon Sep 17 00:00:00 2001 From: Alok Kumar Singh <62210712+akstron@users.noreply.github.com> Date: Mon, 9 Dec 2024 23:40:58 +0530 Subject: [PATCH] Add Comments for CompactionWindow Config Advice (#6331) ## Which problem is this PR solving? - Resolves #3466 ## Description of the changes - Added advice for CompactionWindow config ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: Alok Kumar Singh --- pkg/cassandra/config/config.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/cassandra/config/config.go b/pkg/cassandra/config/config.go index d5e499a2523..9cec5128c4f 100644 --- a/pkg/cassandra/config/config.go +++ b/pkg/cassandra/config/config.go @@ -68,6 +68,8 @@ type Schema struct { ReplicationFactor int `mapstructure:"replication_factor" valid:"optional"` // CompactionWindow is the size of the window for TimeWindowCompactionStrategy. // All SSTables within that window are grouped together into one SSTable. + // Ideally, operators should select a compaction window size that produces approximately less than 50 windows. + // For example, if writing with a 90 day TTL, a 3 day window would be a reasonable choice. CompactionWindow time.Duration `mapstructure:"compaction_window" valid:"optional"` }