Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glob on directories where sensible #23

Open
expipiplus1 opened this issue Oct 18, 2020 · 2 comments
Open

Glob on directories where sensible #23

expipiplus1 opened this issue Oct 18, 2020 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@expipiplus1
Copy link

If a directory is only used by a single component, would it make sense to just attach that directory to a component, instead of listing the files in there individually? This might mean neater hie.yaml files, as well as be a bit more resilient to extra files appearing.

@Avi-D-coder
Copy link
Owner

Probably, I haven't thought about that approach. Contributions welcome.

@jneira
Copy link
Collaborator

jneira commented Oct 20, 2020

Not sure if that will hold for cases where several exes/tests share a common directory and each one picks different modules from it (maybe sharing some of them?)
I think ghcide/hls is stricter nowadays with module targets and it does not discover modules dependencies in its own. TBH Dont know for sure if before that change it caused issues.
Afair for libs we are using the hs-source-dir with no issues.

@Avi-D-coder Avi-D-coder added enhancement New feature or request help wanted Extra attention is needed labels Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants