Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Block] Search: Add dimensions (height, padding, margins) settings #68736

Open
cuemarie opened this issue Oct 6, 2022 · 3 comments
Open

[Block] Search: Add dimensions (height, padding, margins) settings #68736

cuemarie opened this issue Oct 6, 2022 · 3 comments
Labels
[Pri] Normal Schedule for the next available opportuinity. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Feature Request Feature requests

Comments

@cuemarie
Copy link

cuemarie commented Oct 6, 2022

What

It'd be great to see the ability to adjust the height, padding, and margins of the Search block. Right now, we can adjust the Typography settings (font size, and line height) as well as the width of the block, but these options don't offer full customization of the block's input field and button.

Why

This solves the problem of needing to apply CSS to adjust the height and other dimensions of the search block.

Here's an example chat where this came up: 37286617-hc (long chat - search block dimensions chat starts around 2022-10-06 22:12:09 😊 )

How

CSS workaround I offered today was to reduce the internal padding of the block, like this:

.wp-block-search .wp-block-search__input, .wp-block-search .wp-block-search__button {
    padding-top: 3px;
    padding-bottom: 3px;
}

I've seen other approaches in slack as well, such as:

input#wp-block-search__input-5 {
    height: max-content;
}

&

.wp-block-search.wp-block-search__button-inside .wp-block-search__inside-wrapper .wp-block-search__button, .wp-block-search .wp-block-search__button {
    border-width: 0;
    padding-top: inherit;
    padding-bottom: inherit;
}
@cuemarie cuemarie added [Type] Feature Request Feature requests [Pri] Normal Schedule for the next available opportuinity. labels Oct 6, 2022
@cuemarie
Copy link
Author

cuemarie commented Oct 7, 2022

📌 ACTIONS

  • Feature request kept

📌 Message to Author

  • Wow, what a great idea, OP! 😉

📌 Message to Quality Squad

  • Turns out I was next in line to triage my report here. If Quality Squad disagrees with keeping this feature request, feel free to close! 😁

@cuemarie cuemarie added the Triaged To be used when issues have been triaged. label Oct 7, 2022
@cuemarie
Copy link
Author

cuemarie commented Oct 7, 2022

This is included in this Core issue: WordPress/gutenberg#22071

But I'm not sure it's been worked on in a bit.

@cuemarie cuemarie added the [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. label Oct 7, 2022
@mrfoxtalbot mrfoxtalbot moved this to To triage in Dotcom Core Fix Needed Sep 2, 2024
@annezazu
Copy link

Quick note that margin controls have been added but padding hasn't been: WordPress/gutenberg#43243 I updated the related issue in question for now: WordPress/gutenberg#22071

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal Schedule for the next available opportuinity. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Feature Request Feature requests
Projects
None yet
Development

No branches or pull requests

2 participants