-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page Layouts: Layouts Breaking due to User's Account Language on Simple Sites #43732
Comments
Appears related to Automattic/jetpack#15776 cc @sirreal |
This is happening because the translations for the homepages in those four themes are missing for some reason, and it falls back to the default. I opened this issue when I audited the homepage templates: #42368. This is one of the todo items there:
|
Excellent! I totally missed that issue already being open. |
This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels. |
Closing this issue as I believe we've corrected it by serving layouts as patterns from our patterns site. cc @andrewserong |
@nickpagz recently worked with a user that reported broken page layouts.
After review, we identified that the cause was due to the user's WPCOM account language settings. When set to Español, certain page layouts break. They break in the preview and carry over when you choose to use the selected page layout.
Specifically, this occurred when the Maywood theme was active and the user tried to select the Maywood, Shawburn, Twenty Twenty, or Balasana home page layouts on a Simple site.
We have yet to test with other languages, themes, or page layouts. I could not reproduce on Atomic.
Steps to reproduce
What I expected
For page layouts to work across user language settings.
What happened instead
Broken page layouts.
Browser / OS version
Various -- tested across MacOS, Windows, Chrome, and Firefox.
Screenshot / Video
Example of broken page layout:
Various console errors:
Context / Source
Slack discussion: p1593182066424300-slack-wpcom-support
22195250-hc
#user-report
The text was updated successfully, but these errors were encountered: