Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Layouts: Layouts Breaking due to User's Account Language on Simple Sites #43732

Closed
JoshuaGoode opened this issue Jun 26, 2020 · 5 comments
Closed

Comments

@JoshuaGoode
Copy link

JoshuaGoode commented Jun 26, 2020

@nickpagz recently worked with a user that reported broken page layouts.

After review, we identified that the cause was due to the user's WPCOM account language settings. When set to Español, certain page layouts break. They break in the preview and carry over when you choose to use the selected page layout.

Specifically, this occurred when the Maywood theme was active and the user tried to select the Maywood, Shawburn, Twenty Twenty, or Balasana home page layouts on a Simple site.

We have yet to test with other languages, themes, or page layouts. I could not reproduce on Atomic.

Steps to reproduce

  1. Set your interface language to Español on https://wordpress.com/me/account
  2. Create or select a Simple WPCOM site with the Maywood theme
  3. Create a new page or change the page layout of an existing page.
  4. Attempt to use the Maywood, Shawburn, Twenty Twenty, or Balasana home page layouts.
  5. See broken layouts and various browser console errors. Screenshots below.

What I expected

For page layouts to work across user language settings.

What happened instead

Broken page layouts.

Browser / OS version

Various -- tested across MacOS, Windows, Chrome, and Firefox.

Screenshot / Video

Example of broken page layout:
image

Various console errors:
image

Context / Source

Slack discussion: p1593182066424300-slack-wpcom-support

22195250-hc
#user-report

@ianstewart
Copy link
Contributor

Appears related to Automattic/jetpack#15776 cc @sirreal

@iamtakashi
Copy link
Contributor

iamtakashi commented Jun 26, 2020

This is happening because the translations for the homepages in those four themes are missing for some reason, and it falls back to the default. I opened this issue when I audited the homepage templates: #42368.

This is one of the todo items there:

Locate the translations (or make them if it's never translated) for Balasana, Maywood, Shawburn, Twenty Twenty homepages. Test, fix, and deploy the translations so that we stop the confusing experience with the fallback.

@JoshuaGoode
Copy link
Author

I opened this issue when I audited the homepage templates: #42368.

Excellent! I totally missed that issue already being open.

@github-actions
Copy link

github-actions bot commented Mar 2, 2021

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

@ianstewart
Copy link
Contributor

Closing this issue as I believe we've corrected it by serving layouts as patterns from our patterns site. cc @andrewserong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants