Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns: Add keywords to improve search #42906

Closed
ianstewart opened this issue Jun 2, 2020 · 8 comments
Closed

Patterns: Add keywords to improve search #42906

ianstewart opened this issue Jun 2, 2020 · 8 comments
Labels
Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin [Goal] WPCOM Patterns Toolkit Attached to issues and PR related to our block patterns translations project. [Type] Enhancement

Comments

@ianstewart
Copy link
Contributor

It would be great if we could add keywords to Patterns to improve search. Here's an example.

A search for "food" will reveal a food menu …

image

but not other patterns that might be helpful for someone looking for things related to food …

image

Neither of the above patterns would be revealed for someone looking for restaurant-related patterns.

image

@ianstewart ianstewart added [Feature] Block Patterns Pattern content itself, and the functionality that lets you create patterns. [Type] Enhancement labels Jun 2, 2020
@ramonjd
Copy link
Member

ramonjd commented Jun 3, 2020

We haven't lifted a proverbial finger in terms of development, but this idea ties in nicely with discussions we're having about adding metadata to pattern definition files. Don't ask me what those are yet. :)

This also serves to remind us that any metadata, such as search term keywords, must be translatable.

@ramonjd
Copy link
Member

ramonjd commented Jul 13, 2020

I know you've told us before @ianstewart , but just confirming that the patterns source site is https://dotcompatterns.wordpress.com/ ?

🙇‍♂️

@ianstewart
Copy link
Contributor Author

Totes McGoats. All the categories/tags should be up to date there (and easily changed if we've made a mistake). It's a known that some are empty. Some of the empty tags may or may not be filled. Figurin' it out. :)

@ramonjd ramonjd added the Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin label Sep 8, 2020
@ramonjd
Copy link
Member

ramonjd commented Sep 8, 2020

Update: The patterns lib stores the categories of the posts whose content it parses.

We might look at ways to exploit this feature for block patterns integration, building on top of D48036-code

@ramonjd ramonjd added [Goal] WPCOM Patterns Toolkit Attached to issues and PR related to our block patterns translations project. and removed [Feature] Block Patterns Pattern content itself, and the functionality that lets you create patterns. labels Sep 9, 2020
@ramonjd
Copy link
Member

ramonjd commented Sep 10, 2020

I think we almost have everything we need to enable this. See: D49335-code

@ramonjd
Copy link
Member

ramonjd commented Sep 28, 2020

@andrewserong

Can I close D49335-code (a8c-only registration of patterns)?

Has this approach been superseded by your API endpoint in D49914-code?

If so, let me know and we can delete the file entirely that D49335-code modifies.

Also I think we can close this issue since we're adding category and tag filters in D49914-code.

@andrewserong
Copy link
Member

Thanks for the ping @ramonjd! Yes, we can close D49335 now since the work to consume the new endpoint is covered in: #45926, and that will supersede it.

I think it’d be worth keeping this issue (and that backend file) around until #45926 is ready to land so that we make sure this behaviour is covered. I’m happy to update / close this issue when it comes time!

@ramonjd
Copy link
Member

ramonjd commented Sep 28, 2020

I think it’d be worth keeping this issue (and that backend file) around until #45926 is ready to land so that we make sure this behaviour is covered. I’m happy to update / close this issue when it comes time!

Thanks!! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin [Goal] WPCOM Patterns Toolkit Attached to issues and PR related to our block patterns translations project. [Type] Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants