Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg NUX welcome modal: hide per user, not per site-per-user #40040

Closed
simison opened this issue Mar 11, 2020 · 5 comments
Closed

Gutenberg NUX welcome modal: hide per user, not per site-per-user #40040

simison opened this issue Mar 11, 2020 · 5 comments
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg NUX [Type] Enhancement

Comments

@simison
Copy link
Member

simison commented Mar 11, 2020

The welcome guide was enabled for .com in #38511

Via @lancewillett at #38511 (comment):

ith the core guide I find it very annoying to see the tutorial on every internal P2 site that I change over to the block editor (per user, per site).

How might we only show it once per user (regardless of the site where they are opting in)?

With a typical end user, this might be less of an issue, of course.

@olaolusoga @joanrho @dubielzyk thoughts on this?

@simison simison added [Type] Enhancement [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR NUX [Goal] Gutenberg Working towards full integration with Gutenberg labels Mar 11, 2020
@lancewillett
Copy link
Contributor

Another related thought:

If hidden after a first view (any site, same user) — is there an easy way to relaunch it? Self-help where someone wants to watch the tutorial again.

Rather than interrupting the editing flow (blocking a user) — how might we make it available but non-blocking?

@simison
Copy link
Member Author

simison commented Mar 11, 2020

Good question! It's available on the three dots sidebar right now, tho might move to another place in future: WordPress/gutenberg#19499

@olaolusoga
Copy link

It should only show once per user—most folks have 1 site. I think Automatticians are unique cases.

We can set a rules:
If it's a person first site, we should show the modal
If it's a second or more site, we don't, since they are now familiar with the editor.

Since we still have duplicate sites issue, this is something we should consider after we've fixed that bug (unless it's a minority of folks who land on the duplicate site issue)

@noahtallen
Copy link
Contributor

noahtallen commented Mar 12, 2020

This was solved in #39846. It should now only appear one time per user. If you dismiss it again, you will not see it any again. This change probably wasn't deployed at the time the issue was reported here! The FSE update containing the change had to be rolled back, but it should be live now. Please let us know if you continue seeing the issue.

Edit: to clarify, this is live for Simple sites at the moment. Atomic sites have the code, but it is disabled due to an incompatibility issue with core WordPress (so we have to deploy code which checks for compatibility.) This is the bug that caused the outage earlier this week.

@matticbot matticbot removed the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Mar 12, 2020
@noahtallen
Copy link
Contributor

working on the Atomic fix here: #40081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg NUX [Type] Enhancement
Projects
None yet
Development

No branches or pull requests

5 participants