Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Gutenberg tips on WordPress.com and update the copy to be specific and relevant for new users. #38299

Closed
ianstewart opened this issue Dec 9, 2019 · 18 comments · Fixed by #38511
Labels
[Pri] High Address as soon as possible after BLOCKER issues [Status] Needs Design Add this to PRs that need input from Design [Type] Enhancement

Comments

@ianstewart
Copy link
Contributor

ianstewart commented Dec 9, 2019

Suggested, I believe, by @shaunandrews and/or @apeatling. We've disabled Gutenberg tips on WP.com. Can we re-enable them but with content related to our flow and onboarding experience?

@ianstewart
Copy link
Contributor Author

image

image

image

image

@shaunandrews
Copy link
Contributor

shaunandrews commented Dec 9, 2019

The Tips can be some finicky, and don't always point at the right place. But, I think they're still better than nothing.

There was some movement around adding an introduction Modal in Core: WordPress/gutenberg#18041

However, even though that PR is marked as "merged" I've never seen it in reality. Could be a good solution to walking people through their first time experience with Gutenberg.

Edit: It turns out that modal does exist — you can find it in the top-right more menu under "Welcome Guide".

@ianstewart
Copy link
Contributor Author

ianstewart commented Dec 9, 2019

I think we could probably just filter the first sentence in the first block?

"Welcome to our Page Editor!"

But that's a nice-to-have. Like Shaun says, it's better than nothing!

I think we could also correct the core bug in the final tip with some logic for Update vs Publish …

What I saw:

A tip that says, Just click "Publish" and you're good to go. That pointed to a button that says, "Update."

What I expected:

The tip would use the word "Update" when the button says "Update."

@ianstewart
Copy link
Contributor Author

[The onboarding modal] could be a good solution to walking people through their first time experience with Gutenberg.

+1

@simison
Copy link
Member

simison commented Dec 10, 2019

The Tips can be some finicky, and don't always point at the right place. But, I think they're still better than nothing.

Right to assume we'll rely on this mechanism in the future anyway? — so finding any issues and fixing them upstream would be great!

@ianstewart
Copy link
Contributor Author

If we used the tips we could potentially add a custom "final" tip (making the current "publish" tip the second last one) directing people to update their "starter content."

image

@apeatling apeatling added the [Pri] High Address as soon as possible after BLOCKER issues label Dec 10, 2019
@ianstewart
Copy link
Contributor Author

ianstewart commented Dec 10, 2019

And for non-FSE …

image

… we could potentially make the last tip hang off the first heading or paragraph block on the page. Inviting people to update their content after getting to know the Editor.

@apeatling apeatling added [Status] Needs Design Add this to PRs that need input from Design and removed [Status] Needs Design Add this to PRs that need input from Design labels Dec 11, 2019
@Copons Copons self-assigned this Dec 11, 2019
@Copons
Copy link
Contributor

Copons commented Dec 11, 2019

Apparently there are no tips anymore in Core Guten, they’ve been fully replaced by the intro modal.

The DotTip component is still there, but nothing uses it anymore.

At a quick glance, it seems it's a big pain to implement as per design suggestions, since it's intended to be relatively positioned to the element that contains it.
Or, in other words, I have no idea how to nest it into a block component, for example.
It might also become deprecated at some point.

On the other hand, the new WelcomeGuide seems to be using all standard components (aka exported and ready to use).

As far as I can see, we have two clear paths:

  1. We re-enable the Core NUX, and show the Core WelcomeGuide.
  2. We keep disabling the Core WelcomeGuide, and instead provide our own, fully customized for our needs.

I understand it's not exactly the same experience as the DotTip, but it also gives us much more design flexibility.

@ianstewart
Copy link
Contributor Author

Is there any reason not to turn on the core modal Welcome Guide as-is on WP.com?

@ianstewart
Copy link
Contributor Author

#32472

It looks like we turned off the core NUX features previously because it was showing up once per site (or browser cache) and not once per user as expected.

@gwwar
Copy link
Contributor

gwwar commented Dec 11, 2019

I'd recommend not using the core NUX tour directly and creating our own. (We can make our own redux store and re-use existing components, without worrying about integration points from a Gutenberg plugin update).

@lcollette
Copy link
Contributor

I'd recommend not using the core NUX tour directly and creating our own.

+1 to @gwwar's suggestion and reasoning.

@Copons
Copy link
Contributor

Copons commented Dec 11, 2019

IIRC the old Core NUX (aka the tips) also had some positioning issues caused by the fact that WPCOM forces Gutenberg in full screen.

Also, the new NUX uses the same check as the old tips (select( 'core/nux' ).areTipsEnabled()), so WPCOM's disableTips will automatically disable the new NUX as well.

Anyway, if y'all think the new Core NUX is the way to go, I'll start working on the infrastructure ASAP.
We can work copy and images in at a later moment.

@apeatling
Copy link
Member

apeatling commented Dec 11, 2019

@Copons Can we turn on the core nux modal view above for now, but make no changes to it? Keep the tips disabled since that's where it sounds like the issues are? The modal is still an improvement over what we have.

Then we can look at how we might customize this with our own implementation, and also estimate the amount of work to do that.

@simison
Copy link
Member

simison commented Dec 12, 2019

It looks like we turned off the core NUX features previously because it was showing up once per site (or browser cache) and not once per user as expected.

Yep, in core it's indeed cookie-based (visit from another browser and you'll see NUX again).

We'll need our own db-backed mechanism for sure and that's good moment to change it to show up per-user. Again maybe something to contribute to core the way or the other? Cookie-based solution isn't optimal even there.

@zdenys
Copy link
Contributor

zdenys commented Feb 15, 2020

I noticed that some tips are cut off at the top. Here's an example of it on a site with plugins:


Link: https://d.pr/i/j1qBbX

@simison
Copy link
Member

simison commented Feb 17, 2020

@zdenys is that on Atomic or Simple site? If on Atomic, what's the Gutenberg plugin version?

I'm surprised to see those tips instead of welcome modal so I'm suspecting it's Atomic site running older Gutenberg.

@zdenys
Copy link
Contributor

zdenys commented Feb 18, 2020

@simison It was indeed an Atomic site with Gutenberg plugin 7.3 (hence not the most recent version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] High Address as soon as possible after BLOCKER issues [Status] Needs Design Add this to PRs that need input from Design [Type] Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants