Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(1P) Remove Custom Modal overlay CSS in favour of new default #34306

Closed
getdave opened this issue Jun 26, 2019 · 0 comments · Fixed by #34461
Closed

(1P) Remove Custom Modal overlay CSS in favour of new default #34306

getdave opened this issue Jun 26, 2019 · 0 comments · Fixed by #34461
Assignees
@frontdevde
Labels
[Goal] Full Site Editing [Goal] Page Templates
Milestone
Ajax: Iteration 5

Comments

@getdave
Copy link
Contributor

getdave commented Jun 26, 2019 •
edited
Loading

Gutenberg 6.0.0 has landed a new darked modal background making our CSS rules for this unecessary. We can deprecate these rules.

WordPress/gutenberg#15974
@marekhrabe marekhrabe changed the title Remove Custom Modal overlay CSS in favour of new default (1P) Remove Custom Modal overlay CSS in favour of new default Jul 3, 2019
@frontdevde frontdevde self-assigned this Jul 4, 2019
@frontdevde frontdevde mentioned this issue Jul 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frontdevde frontdevde

Labels
[Goal] Full Site Editing [Goal] Page Templates
Projects
None yet
Milestone
Ajax: Iteration 5
Development

Successfully merging a pull request may close this issue.

Remove overlay background color (obsolete due to Gutenberg PR 15974) Automattic/wp-calypso
3 participants
@getdave @obenland @frontdevde