-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outgoing Mentions #213
Outgoing Mentions #213
Conversation
By default, in the Friends plugin, @-mentions of others will be hidden (see akirk/friends#124). This can be changed with a setting on the Edit Feeds page: |
fe9aeda
to
ebe5cc8
Compare
ceb776c
to
d82e388
Compare
This looks great! Once available, I'll tag the authors of ActivityPub and Friends in on a post mentioning my use of it to give it a test. |
a7bb21a
to
5804e20
Compare
@akirk how difficult is it to port the Gutenberg autocomplete feature for the classic block editor. I fear that no one understands the feature and/or does not know how to use it, if there is no GUI?!? |
The autocomplete is actually not part of this PR since it autocompletes local users which are only present if you follow someone with the Friends plugin. You need to manually type the user you'd like to mention and it will be extracted here: https://github.com/pfefferle/wordpress-activitypub/pull/213/files#diff-0c17a58839e890fd735824ceba1483d38496d10ef779994bc90ab9d53843e763R76 |
I understood that, I just feared that noone will understand that this is possible. Maybe we can add a block (that might check the webfinger address) in the future. |
7edc7ec
to
73e56da
Compare
thanks @mexon
…ting to change this
b2d6c03
to
4c8b191
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
With this Pull Request, when you mention another ActivityPub account in the form
[email protected]
(or@[email protected]
), it will add a "tag" and mention the user so that they'll get a notification. It will also send it to their inbox, even if they are not following you.In the Friends Plugin, you can use the Gutenberg autocomplete to just mention a user and it will rewrite the mention to the correct ActivityPub username:
Other
This adds a number of unit tests to ensure that this doesn't break anything.