Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outgoing Mentions #213

Merged
merged 32 commits into from
Jan 27, 2023
Merged

Outgoing Mentions #213

merged 32 commits into from
Jan 27, 2023

Conversation

akirk
Copy link
Member

@akirk akirk commented Dec 9, 2022

With this Pull Request, when you mention another ActivityPub account in the form [email protected] (or @[email protected]), it will add a "tag" and mention the user so that they'll get a notification. It will also send it to their inbox, even if they are not following you.

In the Friends Plugin, you can use the Gutenberg autocomplete to just mention a user and it will rewrite the mention to the correct ActivityPub username:

Screenshot 2022-12-09 at 12 03 31

Other

This adds a number of unit tests to ensure that this doesn't break anything.

@akirk akirk requested a review from pfefferle December 9, 2022 18:07
@akirk
Copy link
Member Author

akirk commented Dec 10, 2022

By default, in the Friends plugin, @-mentions of others will be hidden (see akirk/friends#124). This can be changed with a setting on the Edit Feeds page:

Screenshot 2022-12-10 at 09 36 42

activitypub.php Outdated Show resolved Hide resolved
@HammyHavoc
Copy link

This looks great! Once available, I'll tag the authors of ActivityPub and Friends in on a post mentioning my use of it to give it a test.

@pfefferle
Copy link
Member

@akirk how difficult is it to port the Gutenberg autocomplete feature for the classic block editor. I fear that no one understands the feature and/or does not know how to use it, if there is no GUI?!?

@akirk
Copy link
Member Author

akirk commented Jan 23, 2023

The autocomplete is actually not part of this PR since it autocompletes local users which are only present if you follow someone with the Friends plugin. You need to manually type the user you'd like to mention and it will be extracted here: https://github.com/pfefferle/wordpress-activitypub/pull/213/files#diff-0c17a58839e890fd735824ceba1483d38496d10ef779994bc90ab9d53843e763R76

@akirk
Copy link
Member Author

akirk commented Jan 23, 2023

The idea of this PR is that if you do mention someone via their ActivityPub address, they also get cc-ed and tagged.

@pfefferle
Copy link
Member

I understood that, I just feared that noone will understand that this is possible. Maybe we can add a block (that might check the webfinger address) in the future.

Copy link
Member

@pfefferle pfefferle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants