Mention links overwritten when mentioning a handle where the username existing on the site

[jeherve]

Quick summary

ActivityPub mentions added in #213 are super handy, but they do not seem to work well when mentioning a handle where the username part of the handle is an existing user on the site.

Steps to reproduce

1. On a site with the ActivityPub plugin installed, take note of your own username, e.g. jeremy.
2. In a new post, mention a Fediverse user also using that username, e.g. @[email protected]
3. Preview your post.

What you expected to happen

I would expect the ActivityPub mention to be changed into @jeremy with a link to https://mastodon.social/@jeremy.

What actually happened

The mention text remains, but a link to https://mysite.com/author/jeremy is added instead:

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

Logs or notes

No response

[pfefferle]

Have you clicked the Auto-Suggestion overlay? If I simply type the full WebFinger handle without clicking anywhere else, it works like expected even if there is a local user with the same name.

[jeherve]

That doesn't seem to work that way on my site running ActivityPub + Friends + EMA:

Auto-suggestion pops, but I do not click it.

---

In the editor, I see no link:

---

On the frontend, a link is automatically created:

[pfefferle]

Hmmm, will try that in combination with Friends, but never had any issues so far 😳

[pfefferle]

The weird thing here is, that the HTML looks like the ActivityPub one 🤔

[pfefferle]

Can you maybe try to temporarily deactivate the Friends plugin to try it again?

[pfefferle]

I can reproduce it in combination with the friends plugin!

/cc @akirk

[pfefferle]

@jeherve @akirk maybe we should move the issue to the friends plugin?

[akirk]

Tracking this in akirk/friends#344