From c1d47d9034d2567d5f992f50c145c9f77c0eca92 Mon Sep 17 00:00:00 2001 From: Leonardo Lopes de Albuquerque Date: Tue, 3 Oct 2023 11:27:28 -0300 Subject: [PATCH 1/5] Fixed the version check regex to allow major versions > 9 --- .github/actions/version-check/action.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/actions/version-check/action.yml b/.github/actions/version-check/action.yml index 8eaa13705fb..8b95871a92d 100644 --- a/.github/actions/version-check/action.yml +++ b/.github/actions/version-check/action.yml @@ -29,9 +29,9 @@ runs: TRIMMED_VERSION=$(echo "$VERSION" | xargs) if ${{ env.IS_PRERELEASE == 'true' }}; then - VERSION_FORMAT="^[0-9]\.[0-9]\.[0-9]-test-[1-9]$" + VERSION_FORMAT="^[0-9]+\.[0-9]\.[0-9]-test-[1-9]$" else - VERSION_FORMAT="^[0-9]\.[0-9]\.[0-9]$" + VERSION_FORMAT="^[0-9]+\.[0-9]\.[0-9]$" fi if [[ $TRIMMED_VERSION =~ $VERSION_FORMAT ]]; then From f0917aa2d95dc6c6a626aa69a7c7d4504f2618fe Mon Sep 17 00:00:00 2001 From: Leonardo Lopes de Albuquerque Date: Tue, 3 Oct 2023 11:31:17 -0300 Subject: [PATCH 2/5] Add changelog --- changelog/fix-major-version-check | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 changelog/fix-major-version-check diff --git a/changelog/fix-major-version-check b/changelog/fix-major-version-check new file mode 100644 index 00000000000..2aa8c4cef8d --- /dev/null +++ b/changelog/fix-major-version-check @@ -0,0 +1,4 @@ +Significance: patch +Type: fix + +Fixed version check regex From ad04862fcc10ea2e204dce88f7dfb8f248d5c7b8 Mon Sep 17 00:00:00 2001 From: Leonardo Lopes de Albuquerque Date: Tue, 10 Oct 2023 11:07:06 -0300 Subject: [PATCH 3/5] Fixed the changelog --- changelog/fix-major-version-check | 4 ---- 1 file changed, 4 deletions(-) delete mode 100644 changelog/fix-major-version-check diff --git a/changelog/fix-major-version-check b/changelog/fix-major-version-check deleted file mode 100644 index 2aa8c4cef8d..00000000000 --- a/changelog/fix-major-version-check +++ /dev/null @@ -1,4 +0,0 @@ -Significance: patch -Type: fix - -Fixed version check regex From 51f4640bbed0b0730850add21c0ace3a976baae4 Mon Sep 17 00:00:00 2001 From: Leonardo Lopes de Albuquerque Date: Tue, 10 Oct 2023 11:09:26 -0300 Subject: [PATCH 4/5] Fixed regex to allow xx.x.xx versions --- .github/actions/version-check/action.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/actions/version-check/action.yml b/.github/actions/version-check/action.yml index 8b95871a92d..0a2627ec047 100644 --- a/.github/actions/version-check/action.yml +++ b/.github/actions/version-check/action.yml @@ -29,9 +29,9 @@ runs: TRIMMED_VERSION=$(echo "$VERSION" | xargs) if ${{ env.IS_PRERELEASE == 'true' }}; then - VERSION_FORMAT="^[0-9]+\.[0-9]\.[0-9]-test-[1-9]$" + VERSION_FORMAT="^[0-9]+\.[0-9]\.[0-9]+-test-[1-9]$" else - VERSION_FORMAT="^[0-9]+\.[0-9]\.[0-9]$" + VERSION_FORMAT="^[0-9]+\.[0-9]\.[0-9]+$" fi if [[ $TRIMMED_VERSION =~ $VERSION_FORMAT ]]; then From 427a205a4a8266297618fba529a9d7b76f1532c8 Mon Sep 17 00:00:00 2001 From: Leonardo Lopes de Albuquerque Date: Tue, 10 Oct 2023 11:16:12 -0300 Subject: [PATCH 5/5] readded changelog --- changelog/fix-major-version-check | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 changelog/fix-major-version-check diff --git a/changelog/fix-major-version-check b/changelog/fix-major-version-check new file mode 100644 index 00000000000..205c41a7451 --- /dev/null +++ b/changelog/fix-major-version-check @@ -0,0 +1,4 @@ +Significance: patch +Type: dev + +Fixed version check regex