Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile layout & styling fixes and improvements for Payment details when payment is disputed #7230

Closed
brucealdridge opened this issue Sep 19, 2023 · 5 comments · Fixed by #9790
Assignees
Labels
component: disputes Issues related to Disputes focus: disputes good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: bug The issue is a confirmed bug.

Comments

@brucealdridge
Copy link
Contributor

brucealdridge commented Sep 19, 2023

Describe the bug

On the payments summary page with a dispute the mobile view needs some styling changes.

  • When the pill for the payment - Disputed: Needs response - the label can sit outside the Card element.
  • Padding consistency

Current View
image

Changes Required

image

RiEQmaKRI7u9USAI3lyZz0VX-fi-7430%3A30973

To Reproduce

  1. On WooPayments 6.5 set the feature flag on update_option( '_wcpay_feature_dispute_on_transaction_page', '1' );
  2. Create a disputed transaction using the card 4000000000000259 at checkout.
  3. Find the dispute in Payments → Disputes and click it to view the dispute details screen on mobile.

Additional context

p1695089677913989-slack-C03LA109BKM

@brucealdridge brucealdridge added type: bug The issue is a confirmed bug. component: disputes Issues related to Disputes labels Sep 19, 2023
@zmaglica
Copy link
Contributor

This issue impacts disputes, so assigning to team Helix. (based on team responsibilities Pc2DNy-3z-p2) @haszari Assigning as part of Gamma Triage process PcreKM-yM-p2.

@zmaglica zmaglica added the category: core WC Payments core related issues, where it’s obvious. label Sep 25, 2023
@brucealdridge brucealdridge added category: projects For any issues which are part of any project, including bugs, enhancements, etc. and removed category: core WC Payments core related issues, where it’s obvious. labels Sep 25, 2023
@haszari
Copy link
Contributor

haszari commented Sep 26, 2023

As discussed with @nikkivias and team in slack, there's a bigger issue here which we might want to look at in future. This issue is to fix specific pain points with current design.

The "you have a dispute" notice illustrates the problem. It's nested three levels deep:

  • Transaction detail box
    • Dispute detail box
      • Dispute needs response notice

And on mobile, that nesting makes for a very small box, and lots of margins!

Screenshot 2023-09-26 at 2 07 49 PM

@nikkivias
Copy link

Hi team, I've previously mentioned that there is not much room to compromise here as the dispute notice HAS to be contained and made separate from the rest of the details. The idea here is that the dispute details are akin to a yellow notice slapped onto a transaction. I think the bigger issue here is that the dispute details is so far down on mobile, but that is another problem, for maybe another team lol.

However I definitely recognize the marg-inception 🤓 situation here, I was wondering if the banner itself could be made to fill the entire container. Please see mockup

image

@haszari haszari removed the category: projects For any issues which are part of any project, including bugs, enhancements, etc. label Jan 31, 2024
@haszari
Copy link
Contributor

haszari commented Jan 31, 2024

Removing projects, this is a bug that we can add to maintenance backlog.

@haszari haszari added the priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability label Feb 8, 2024
@naman03malhotra naman03malhotra self-assigned this Mar 14, 2024
@haszari haszari added the good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. label Oct 17, 2024
@haszari haszari changed the title Payments Summary with dispute details - Style changes for mobile. Layout & styling fixes and improvements for Payment details when payment is disputed Nov 14, 2024
@haszari
Copy link
Contributor

haszari commented Nov 14, 2024

Next steps:

  • Review description, comments and UI and list essential styling tweaks/fixes.
  • Implement the fixes!

@shendy-a8c shendy-a8c self-assigned this Nov 20, 2024
@brucealdridge brucealdridge changed the title Layout & styling fixes and improvements for Payment details when payment is disputed Mobile layout & styling fixes and improvements for Payment details when payment is disputed Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: disputes Issues related to Disputes focus: disputes good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants