Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type styles to latest design standards #427

Closed
dechov opened this issue Feb 13, 2020 · 1 comment
Closed

Update type styles to latest design standards #427

dechov opened this issue Feb 13, 2020 · 1 comment
Labels
category: core WC Payments core related issues, where it’s obvious. needs prioritisation Triage finished and issues are ready for the following processing. type: enhancement The issue is a request for an enhancement.

Comments

@dechov
Copy link
Contributor

dechov commented Feb 13, 2020

See @LevinMedia's note on type styles in #418 (comment), in the context of the dispute details screen but applicable in a general way across this app as well as upstream components:

If you could, please align them to the type scale described in the Figma file.

The card headers use Title S with $studio-gray-80 color

The card bodies use Body with $studio-gray-60 as the color

The bold text that separates paragraphs in the second card are also body but bold, and using $studio-gray-80 as the color

per our slack chat - hopefully type scale linked above will soon be included with gutenberg, until that time we can hard code it.

If too much time passes though, we'll probably want to include the type scale as part of @woocommerce/components - as we're using it elsewhere in new designs across WooCommerce such as onboarding and other new screens in wc-admin.

@vbelolapotkov vbelolapotkov added category: core WC Payments core related issues, where it’s obvious. type: enhancement The issue is a request for an enhancement. needs prioritisation Triage finished and issues are ready for the following processing. labels Dec 22, 2021
@LevinMedia
Copy link
Contributor

No longer relevant - closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: core WC Payments core related issues, where it’s obvious. needs prioritisation Triage finished and issues are ready for the following processing. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

4 participants