Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate padding between help text and input #1952

Closed
frosso opened this issue May 27, 2021 · 2 comments
Closed

Investigate padding between help text and input #1952

frosso opened this issue May 27, 2021 · 2 comments
Assignees
Labels
component: grouped-settings priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc.

Comments

@frosso
Copy link
Contributor

frosso commented May 27, 2021

Description

For background info: p1622132280144800-slack-CU6SYV31A

I wonder if there’s a way to increase the padding between the checkbox label and its description? 12 px would be perfect. I’ve also removed the link to Microsoft docs and updated the designs in Figma.

The padding comes from Gutenberg. Would it be fixed with a newer version of Gutenberg, without having to adjust all the BaseControl components?

@frosso frosso added component: grouped-settings priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. labels May 27, 2021
@frosso frosso self-assigned this Jun 7, 2021
@frosso
Copy link
Contributor Author

frosso commented Jun 7, 2021

This is the change that interests us: WordPress/gutenberg#29550

With the Gutenberg release that includes that change (I just tested the last one), I can see the margin between the help text and the input being adjusted:
Screen Shot 2021-06-07 at 3 35 53 PM

At the time of writing:

Should we include the latest version of @wordpress/components with the 2.6 release?

Asked for feedback here: p1623099616037700-slack-C0208C3BXHP

@frosso
Copy link
Contributor Author

frosso commented Jun 8, 2021

Talked to the team about it.
Upgrading Gutenberg to the latest major version is definitely the way to go.

I created a ticket for the upgrade: #2085
Design asked to adjust the margin for the settings page, I opened a PR to tweak that: #2084

In the ticket I specified that the patch can be removed when the upgrade is done.
The patch should not conflict with the upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: grouped-settings priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc.
Projects
None yet
Development

No branches or pull requests

1 participant