Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructuring auto-approvals to provide more consistency #277

Open
gudmdharalds opened this issue Jun 7, 2022 · 0 comments
Open

Restructuring auto-approvals to provide more consistency #277

gudmdharalds opened this issue Jun 7, 2022 · 0 comments

Comments

@gudmdharalds
Copy link
Contributor

gudmdharalds commented Jun 7, 2022

Feature request

Auto-approval functionality needs restructuring so to provide more consistency. vip-go-ci needs to keep a record of approved files per pull request processed.

Background of feature request

Currently, vip-go-ci relies on file-names for auto-approvals. Hence, when a file is found to be auto-approvable, it is added to an array of approved files. However, this can be problematic, for example when multiple pull requests are being processed which make different changes to the auto-approved files: In one pull request, changes to one file are trivial, but much larger in an other one. This can cause problems, though it is rare.

Description of feature

To improve this vip-go-ci needs to keep a record of which files are approved per pull-request, and use it when approving each pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant