Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SVG scanning independent of PHPCS #146

Open
gudmdharalds opened this issue Jan 12, 2021 · 0 comments
Open

Make SVG scanning independent of PHPCS #146

gudmdharalds opened this issue Jan 12, 2021 · 0 comments

Comments

@gudmdharalds
Copy link
Contributor

gudmdharalds commented Jan 12, 2021

Currently, SVG scanning functionality is implemented as part of PHPCS scanning, so that no SVG files are scanned if PHPCS is disabled. Also, results of SVG scanning is reported as PHPCS. This can be confusing to users and makes the statistics reported look a bit weird.

Further, auto-approvals of SVG files is performed when --svg-checks parameter is set to true, which is also used to indicate SVG scanning. This should be independent of each other: a) auto-approval of SVG files is done when configured to do so and no issues are found (using --auto-approve-svg-when-no-issues), and, b) issues in SVG files are reported if configured to do so (using --svg).

SVG scanning should be fully independent of PHPCS scanning, having its own statistics type and so forth. Auto-approval of SVG files should be independent of SVG scanning and reporting.

Relevant code:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant