From 2cadcffc4dd6c57d4c87c0e7900049e730d2d0d9 Mon Sep 17 00:00:00 2001 From: "Gudmundur D. Haraldsson" Date: Mon, 30 Oct 2023 16:38:20 +0000 Subject: [PATCH 1/2] Update defines.php --- defines.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/defines.php b/defines.php index 71c54552..de9b379b 100644 --- a/defines.php +++ b/defines.php @@ -16,8 +16,8 @@ /* * Define minimum version requirements. */ -define( 'VIPGOCI_GIT_VERSION_MINIMUM', '2.10' ); -define( 'VIPGOCI_PHP_VERSION_MINIMUM', '7.3.0' ); +define( 'VIPGOCI_GIT_VERSION_MINIMUM', '2.30' ); +define( 'VIPGOCI_PHP_VERSION_MINIMUM', '8.0.0' ); /* * Client-ID for HTTP requests. From eb191745bf5fc70bc94f411a69a1fdb19dcbbdb3 Mon Sep 17 00:00:00 2001 From: "Gudmundur D. Haraldsson" Date: Mon, 30 Oct 2023 16:42:50 +0000 Subject: [PATCH 2/2] Update PULL_REQUEST_TEMPLATE --- .github/PULL_REQUEST_TEMPLATE | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE index 6ae086a8..35d9b83b 100644 --- a/.github/PULL_REQUEST_TEMPLATE +++ b/.github/PULL_REQUEST_TEMPLATE @@ -14,6 +14,9 @@ TODO: - [ ] Added patch for [describe issue] - [ ] Add/update tests -- unit/integrated/E2E (if needed) - [ ] Ensure only one function/functionality is tested per test file. +- [ ] New/updated software requirements? + - [ ] Update README.md + - [ ] Update defines.php - [ ] Add to, or update, `Scan run detail` report as applicable - [ ] Check status of automated tests - [ ] Ensure `PHPDoc` comments are up to date for functions added or altered @@ -31,6 +34,9 @@ TODO: - [ ] Add to, or update, `Scan run detail` report as applicable - [ ] Add/update tests -- unit/integrated/E2E - [ ] Ensure only one function/functionality is tested per test file. +- [ ] New/updated software requirements? + - [ ] Update README.md + - [ ] Update defines.php - [ ] Ensure `PHPDoc` comments are up to date for functions added or altered - [ ] Update repository documentation (README.md, RELEASING.md, TESTING.md, TOOLS-UPDATE.md) - [ ] Assign appropriate [priority](https://github.com/Automattic/vip-go-ci/blob/trunk/CONTRIBUTING.md#priorities) and [type of change labels](https://github.com/Automattic/vip-go-ci/blob/trunk/CONTRIBUTING.md#type-of-change-labels).