refactor(skeleton): switch to busybox and simplify build
#1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trivy Scan ReportTrivy Returned Empty Report |
Trivy Scan ReportTrivy Returned Empty Report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the base image for
skeletonfromalpinetobusybox. This reduces the image size (22.5MB vs 32.9MB) and update frequency (thebusyboxbinary is the only executable component of the image; it is updated less frequently and has much fewer vulnerabilities than a full-fledged image).Also, because the
ADDcommand can add files from a Git repository, we simplify the build process by not usinggit. The build process will be faster because Docker does not need to execute anything in the foreign (emulated) architecture.Unlike #984, this PR does not require changes to VIP CLI.