Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issues found by SonarCloud #1638

Merged
merged 1 commit into from
Jan 9, 2024
Merged

fix: issues found by SonarCloud #1638

merged 1 commit into from
Jan 9, 2024

Conversation

sjinks
Copy link
Member

@sjinks sjinks commented Jan 9, 2024

Description

This PR fixes maintainability issues found by SonarCloud:

  • Optional chaining should be preferred (javascript:S6582)
  • Object spread syntax should be used instead of "Object.assign" (javascript:S6661)
  • Use Object.hasOwn static method instead of hasOwnProperty (javascript:S6653)

Pull request checklist

New release checklist

Steps to Test

All existing tests should pass.

@sjinks sjinks self-assigned this Jan 9, 2024
@sjinks sjinks force-pushed the fix/sonarcloud-issues branch from 5b441ff to be4a2d2 Compare January 9, 2024 21:52
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sjinks sjinks merged commit 09c79ce into trunk Jan 9, 2024
14 checks passed
@sjinks sjinks deleted the fix/sonarcloud-issues branch January 9, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinatkhaziev rinatkhaziev rinatkhaziev approved these changes

Assignees

@sjinks sjinks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjinks @rinatkhaziev