From 0755cc0543779bb2232a9717f492063118ac70f3 Mon Sep 17 00:00:00 2001
From: Ben Dwyer <ben@scruffian.com>
Date: Fri, 27 Aug 2021 13:14:31 +0100
Subject: [PATCH 01/10] Blockbase: Add social navigation to blockbase themes

---
 blockbase/functions.php                         | 7 ++++---
 mayland-blocks/block-template-parts/header.html | 1 +
 mayland-blocks/functions.php                    | 7 -------
 quadrat/functions.php                           | 7 -------
 seedlet-blocks/block-template-parts/header.html | 2 ++
 seedlet-blocks/functions.php                    | 7 -------
 skatepark/functions.php                         | 8 --------
 7 files changed, 7 insertions(+), 32 deletions(-)

diff --git a/blockbase/functions.php b/blockbase/functions.php
index 9c3e2c2e33..ce288fca8a 100644
--- a/blockbase/functions.php
+++ b/blockbase/functions.php
@@ -30,10 +30,11 @@ function blockbase_support() {
 			)
 		);
 
-		// This theme has one menu location.
+		// Register two nav menus
 		register_nav_menus(
 			array(
 				'primary' => __( 'Primary Navigation', 'blockbase' ),
+				'social' => __( 'Social Navigation', 'blockbase' )
 			)
 		);
 
@@ -193,8 +194,8 @@ function blockbase_social_menu_render( $block_content, $block ) {
 		$nav_menu_locations = get_nav_menu_locations();
 		$social_menu_id = $nav_menu_locations['social'];
 		$class_name = 'is-style-logos-only';
-		if( !empty( $block['attrs']['itemsJustification'] ) && $block['attrs']['itemsJustification'] === 'right' ) {
-			$class_name .= ' items-justified-right';
+		if( !empty( $block['attrs']['itemsJustification'] ) ) {
+			$class_name .= ' items-justified-' . $block['attrs']['itemsJustification'];
 		}
 		$block_content = '<!-- wp:social-links {"iconColor":"primary","iconColorValue":"var(--wp--custom--color--primary)","className":"' . $class_name . '"} --><ul class="wp-block-social-links has-icon-color ' . $class_name . '">';
 		$menu = wp_get_nav_menu_items( $social_menu_id );
diff --git a/mayland-blocks/block-template-parts/header.html b/mayland-blocks/block-template-parts/header.html
index df620e50d1..0a16240cfd 100644
--- a/mayland-blocks/block-template-parts/header.html
+++ b/mayland-blocks/block-template-parts/header.html
@@ -5,5 +5,6 @@
 <!-- wp:site-tagline {"fontSize":"tiny"} /-->
 <!-- wp:navigation {"orientation":"horizontal","textColor":"foreground-light","itemsJustification":"right","fontSize":"small","isResponsive":true,"__unstableLocation":"primary"} -->
 <!-- /wp:navigation -->
+<!-- wp:navigation {"orientation":"horizontal","itemsJustification":"right","isResponsive":true,"__unstableLocation":"social"} --><!-- /wp:navigation -->
 </div>
 <!-- /wp:group -->
diff --git a/mayland-blocks/functions.php b/mayland-blocks/functions.php
index 53a0811cab..c95d6cc234 100644
--- a/mayland-blocks/functions.php
+++ b/mayland-blocks/functions.php
@@ -10,13 +10,6 @@ function mayland_blocks_support() {
 			)
 		);
 
-		// This theme has one menu location.
-		register_nav_menus(
-			array(
-				'primary' => __( 'Primary Navigation', 'mayland-blocks' ),
-			)
-		);
-
 	}
 	add_action( 'after_setup_theme', 'mayland_blocks_support' );
 endif;
diff --git a/quadrat/functions.php b/quadrat/functions.php
index b2fc4b5ba9..336028213b 100644
--- a/quadrat/functions.php
+++ b/quadrat/functions.php
@@ -17,13 +17,6 @@ function quadrat_support() {
 			'starter-content',
 			$quadrat_starter_content
 		);
-
-		// This theme uses wp_nav_menu() in two locations.
-		register_nav_menus(
-			array(
-				'primary' => __( 'Primary Navigation', 'quadrat' ),
-			)
-		);
 	}
 	add_action( 'after_setup_theme', 'quadrat_support' );
 endif;
diff --git a/seedlet-blocks/block-template-parts/header.html b/seedlet-blocks/block-template-parts/header.html
index ca903a93c4..97ec124b03 100644
--- a/seedlet-blocks/block-template-parts/header.html
+++ b/seedlet-blocks/block-template-parts/header.html
@@ -11,6 +11,8 @@
 <!-- wp:navigation {"itemsJustification":"center","isResponsive":true,"__unstableLocation":"primary"} -->
 <!-- /wp:navigation -->
 
+<!-- wp:navigation {"orientation":"horizontal","itemsJustification":"center","isResponsive":true,"__unstableLocation":"social"} --><!-- /wp:navigation -->
+
 <!-- wp:spacer {"height":60} -->
 <div style="height:60px" aria-hidden="true" class="wp-block-spacer"></div>
 <!-- /wp:spacer -->
diff --git a/seedlet-blocks/functions.php b/seedlet-blocks/functions.php
index ea391ff237..caa759c9d8 100755
--- a/seedlet-blocks/functions.php
+++ b/seedlet-blocks/functions.php
@@ -12,13 +12,6 @@ function seedlet_blocks_support() {
 		)
 	);
 
-	// This theme has one menu location.
-	register_nav_menus(
-		array(
-			'primary' => __( 'Primary Navigation', 'seedlet-blocks' ),
-		)
-	);
-
 }
 add_action( 'after_setup_theme', 'seedlet_blocks_support' );
 
diff --git a/skatepark/functions.php b/skatepark/functions.php
index 4fd18198f2..b52916524b 100644
--- a/skatepark/functions.php
+++ b/skatepark/functions.php
@@ -9,14 +9,6 @@ function skatepark_support() {
 				'/assets/theme.css',
 			)
 		);
-
-		//Primary navigation is used on the header and the footer pattern
-		register_nav_menus(
-			array(
-				'primary' => __( 'Primary Navigation', 'skatepark' ),
-				'social' => __( 'Social Navigation', 'skatepark' )
-			)
-		);
 	}
 	add_action( 'after_setup_theme', 'skatepark_support' );
 endif;

From fda3f37caaead124cec4da46f814cfb629db6bc0 Mon Sep 17 00:00:00 2001
From: Ben Dwyer <ben@scruffian.com>
Date: Fri, 1 Oct 2021 12:44:14 +0100
Subject: [PATCH 02/10] Add social navigation links to primary navigation

---
 blockbase/functions.php                       | 49 ++++++++++++-------
 .../block-template-parts/header.html          |  1 -
 .../block-template-parts/header.html          |  2 -
 skatepark/block-template-parts/header.html    |  3 --
 4 files changed, 32 insertions(+), 23 deletions(-)

diff --git a/blockbase/functions.php b/blockbase/functions.php
index ce288fca8a..c1f8df46dc 100644
--- a/blockbase/functions.php
+++ b/blockbase/functions.php
@@ -181,32 +181,47 @@ function blockbase_condition_to_render_social_menu( $block ) {
 		return false;
 	}
 
-	// The block's location should be 'social'.
-	if ( $block['attrs']['__unstableLocation'] !== 'social' ) {
+	// The block's location should be 'primary'.
+	if ( $block['attrs']['__unstableLocation'] !== 'primary' ) {
 		return false;
 	}
 
 	return true;
 }
 
+function get_social_menu_as_social_links_block() {
+	$nav_menu_locations = get_nav_menu_locations();
+	$social_menu_id = $nav_menu_locations['social'];
+	$class_name = 'is-style-logos-only';
+	if( ! empty( $block['attrs']['itemsJustification'] ) ) {
+		$class_name .= ' items-justified-' . $block['attrs']['itemsJustification'];
+	}
+	$social_links_content = '<!-- wp:social-links {"iconColor":"primary","iconColorValue":"var(--wp--custom--color--primary)","className":"' . $class_name . '"} --><ul class="wp-block-social-links has-icon-color ' . $class_name . '">';
+	$menu = wp_get_nav_menu_items( $social_menu_id );
+	foreach ($menu as $menu_item) {
+		$service_name = preg_replace( '/(-[0-9]+)/', '', $menu_item->post_name );
+		$social_links_content .= '<!-- wp:social-link {"url":"' . $menu_item->url . '","service":"' . $service_name . '"} /-->';
+	}
+	$social_links_content .= '</ul><!-- /wp:social-links -->';
+	return do_blocks( $social_links_content );
+}
+
+function append_social_links_block_to_primary_navigation( $primary_navigation, $social_links_block ) {
+	$dom = new domDocument;
+	$dom->loadHTML( $primary_navigation );
+	$wp_block_navigation__container = $dom->getElementsByTagName('ul')->item( 0 );
+	$social_links_node = $dom->createDocumentFragment();
+	$social_links_node->appendXML( $social_links_block );
+	$wp_block_navigation__container->appendChild( $social_links_node );
+	$navigation_block = $dom->getElementsByTagName('nav')->item( 0 );
+	return $dom->saveXML( $navigation_block );
+}
+
 function blockbase_social_menu_render( $block_content, $block ) {
 	if ( blockbase_condition_to_render_social_menu( $block ) ) {
-		$nav_menu_locations = get_nav_menu_locations();
-		$social_menu_id = $nav_menu_locations['social'];
-		$class_name = 'is-style-logos-only';
-		if( !empty( $block['attrs']['itemsJustification'] ) ) {
-			$class_name .= ' items-justified-' . $block['attrs']['itemsJustification'];
-		}
-		$block_content = '<!-- wp:social-links {"iconColor":"primary","iconColorValue":"var(--wp--custom--color--primary)","className":"' . $class_name . '"} --><ul class="wp-block-social-links has-icon-color ' . $class_name . '">';
-		$menu = wp_get_nav_menu_items( $social_menu_id );
-		foreach ($menu as $menu_item) {
-			$service_name = preg_replace( '/(-[0-9]+)/', '', $menu_item->post_name );
-			$block_content .= '<!-- wp:social-link {"url":"' . $menu_item->url . '","service":"' . $service_name . '"} /-->';
-		}
-
-		$block_content .= '</ul>';
+		$social_links_block = get_social_menu_as_social_links_block();
 
-		return do_blocks( $block_content );
+		return append_social_links_block_to_primary_navigation( $block_content, $social_links_block );
 	}
 
 	return $block_content;
diff --git a/mayland-blocks/block-template-parts/header.html b/mayland-blocks/block-template-parts/header.html
index 0a16240cfd..df620e50d1 100644
--- a/mayland-blocks/block-template-parts/header.html
+++ b/mayland-blocks/block-template-parts/header.html
@@ -5,6 +5,5 @@
 <!-- wp:site-tagline {"fontSize":"tiny"} /-->
 <!-- wp:navigation {"orientation":"horizontal","textColor":"foreground-light","itemsJustification":"right","fontSize":"small","isResponsive":true,"__unstableLocation":"primary"} -->
 <!-- /wp:navigation -->
-<!-- wp:navigation {"orientation":"horizontal","itemsJustification":"right","isResponsive":true,"__unstableLocation":"social"} --><!-- /wp:navigation -->
 </div>
 <!-- /wp:group -->
diff --git a/seedlet-blocks/block-template-parts/header.html b/seedlet-blocks/block-template-parts/header.html
index 97ec124b03..ca903a93c4 100644
--- a/seedlet-blocks/block-template-parts/header.html
+++ b/seedlet-blocks/block-template-parts/header.html
@@ -11,8 +11,6 @@
 <!-- wp:navigation {"itemsJustification":"center","isResponsive":true,"__unstableLocation":"primary"} -->
 <!-- /wp:navigation -->
 
-<!-- wp:navigation {"orientation":"horizontal","itemsJustification":"center","isResponsive":true,"__unstableLocation":"social"} --><!-- /wp:navigation -->
-
 <!-- wp:spacer {"height":60} -->
 <div style="height:60px" aria-hidden="true" class="wp-block-spacer"></div>
 <!-- /wp:spacer -->
diff --git a/skatepark/block-template-parts/header.html b/skatepark/block-template-parts/header.html
index ef55d21dc6..ce91e1ab9f 100644
--- a/skatepark/block-template-parts/header.html
+++ b/skatepark/block-template-parts/header.html
@@ -11,9 +11,6 @@
 <div class="wp-block-group nav-links"><!-- wp:navigation {"orientation":"horizontal","itemsJustification":"right","isResponsive":true,"__unstableLocation":"primary","style":{"typography":{"fontStyle":"normal","fontWeight":"900","textTransform":"uppercase"}},"fontSize":"small"} -->
 <!-- /wp:navigation -->
 
-<!-- wp:navigation {"orientation":"horizontal","itemsJustification":"right","isResponsive":true,"__unstableLocation":"social"} --><!-- /wp:navigation -->
-
-
 </div>
 <!-- /wp:group -->
 </div>

From 1ebd2eaeaa7e83b6497b3b4fccbb90f3b6da3d09 Mon Sep 17 00:00:00 2001
From: Ben Dwyer <ben@scruffian.com>
Date: Fri, 1 Oct 2021 15:28:54 +0100
Subject: [PATCH 03/10] move to a different file

---
 blockbase/functions.php | 71 ++---------------------------------------
 1 file changed, 2 insertions(+), 69 deletions(-)

diff --git a/blockbase/functions.php b/blockbase/functions.php
index c1f8df46dc..e25d0eec45 100644
--- a/blockbase/functions.php
+++ b/blockbase/functions.php
@@ -144,6 +144,8 @@ function blockbase_restore_customizer() {
 	require get_template_directory() . '/inc/customizer/wp-customize-fonts.php';
 }
 
+require get_template_directory() . '/inc/social-navigation.php';
+
 // Force menus to reload
 add_action(
 	'customize_controls_enqueue_scripts',
@@ -157,72 +159,3 @@ static function () {
 		);
 	}
 );
-
-/**
- * Populate the social links block with the social menu content if it exists
- *
- */
-add_filter( 'render_block', 'blockbase_social_menu_render', 10, 2 );
-// We should only change the render of the navigtion block
-// to social links in the following conditions.
-function blockbase_condition_to_render_social_menu( $block ) {
-	// The block should be a navigation block.
-	if ( 'core/navigation' !== $block['blockName'] ) {
-		return false;
-	}
-
-	// The theme should have a menu defined at the social location.
-	if ( ! has_nav_menu( 'social' ) ) {
-		return false;
-	}
-
-	// The block should have a loction defined.
-	if ( empty( $block['attrs']['__unstableLocation'] ) ) {
-		return false;
-	}
-
-	// The block's location should be 'primary'.
-	if ( $block['attrs']['__unstableLocation'] !== 'primary' ) {
-		return false;
-	}
-
-	return true;
-}
-
-function get_social_menu_as_social_links_block() {
-	$nav_menu_locations = get_nav_menu_locations();
-	$social_menu_id = $nav_menu_locations['social'];
-	$class_name = 'is-style-logos-only';
-	if( ! empty( $block['attrs']['itemsJustification'] ) ) {
-		$class_name .= ' items-justified-' . $block['attrs']['itemsJustification'];
-	}
-	$social_links_content = '<!-- wp:social-links {"iconColor":"primary","iconColorValue":"var(--wp--custom--color--primary)","className":"' . $class_name . '"} --><ul class="wp-block-social-links has-icon-color ' . $class_name . '">';
-	$menu = wp_get_nav_menu_items( $social_menu_id );
-	foreach ($menu as $menu_item) {
-		$service_name = preg_replace( '/(-[0-9]+)/', '', $menu_item->post_name );
-		$social_links_content .= '<!-- wp:social-link {"url":"' . $menu_item->url . '","service":"' . $service_name . '"} /-->';
-	}
-	$social_links_content .= '</ul><!-- /wp:social-links -->';
-	return do_blocks( $social_links_content );
-}
-
-function append_social_links_block_to_primary_navigation( $primary_navigation, $social_links_block ) {
-	$dom = new domDocument;
-	$dom->loadHTML( $primary_navigation );
-	$wp_block_navigation__container = $dom->getElementsByTagName('ul')->item( 0 );
-	$social_links_node = $dom->createDocumentFragment();
-	$social_links_node->appendXML( $social_links_block );
-	$wp_block_navigation__container->appendChild( $social_links_node );
-	$navigation_block = $dom->getElementsByTagName('nav')->item( 0 );
-	return $dom->saveXML( $navigation_block );
-}
-
-function blockbase_social_menu_render( $block_content, $block ) {
-	if ( blockbase_condition_to_render_social_menu( $block ) ) {
-		$social_links_block = get_social_menu_as_social_links_block();
-
-		return append_social_links_block_to_primary_navigation( $block_content, $social_links_block );
-	}
-
-	return $block_content;
-}

From 6cf2f26dab4ca3a1f17c512b58502b96af27afb6 Mon Sep 17 00:00:00 2001
From: Ben Dwyer <ben@scruffian.com>
Date: Fri, 1 Oct 2021 15:54:29 +0100
Subject: [PATCH 04/10] add missing file

---
 blockbase/inc/social-navigation.php | 70 +++++++++++++++++++++++++++++
 1 file changed, 70 insertions(+)
 create mode 100644 blockbase/inc/social-navigation.php

diff --git a/blockbase/inc/social-navigation.php b/blockbase/inc/social-navigation.php
new file mode 100644
index 0000000000..ac5bd6ea32
--- /dev/null
+++ b/blockbase/inc/social-navigation.php
@@ -0,0 +1,70 @@
+<?php
+
+// We should only change the render of the navigtion block
+// to social links in the following conditions.
+function blockbase_condition_to_render_social_menu( $block ) {
+	// The block should be a navigation block.
+	if ( 'core/navigation' !== $block['blockName'] ) {
+		return false;
+	}
+
+	// The theme should have a menu defined at the social location.
+	if ( ! has_nav_menu( 'social' ) ) {
+		return false;
+	}
+
+	// The block should have a loction defined.
+	if ( empty( $block['attrs']['__unstableLocation'] ) ) {
+		return false;
+	}
+
+	// The block's location should be 'primary'.
+	if ( $block['attrs']['__unstableLocation'] !== 'primary' ) {
+		return false;
+	}
+
+	return true;
+}
+
+function get_social_menu_as_social_links_block() {
+	$nav_menu_locations = get_nav_menu_locations();
+	$social_menu_id = $nav_menu_locations['social'];
+	$class_name = 'is-style-logos-only';
+	if( ! empty( $block['attrs']['itemsJustification'] ) ) {
+		$class_name .= ' items-justified-' . $block['attrs']['itemsJustification'];
+	}
+	$social_links_content = '<!-- wp:social-links {"iconColor":"primary","iconColorValue":"var(--wp--custom--color--primary)","className":"' . $class_name . '"} --><ul class="wp-block-social-links has-icon-color ' . $class_name . '">';
+	$menu = wp_get_nav_menu_items( $social_menu_id );
+	foreach ($menu as $menu_item) {
+		$service_name = preg_replace( '/(-[0-9]+)/', '', $menu_item->post_name );
+		$social_links_content .= '<!-- wp:social-link {"url":"' . $menu_item->url . '","service":"' . $service_name . '"} /-->';
+	}
+	$social_links_content .= '</ul><!-- /wp:social-links -->';
+	return do_blocks( $social_links_content );
+}
+
+function append_social_links_block_to_primary_navigation( $primary_navigation, $social_links_block ) {
+	$dom = new domDocument;
+	$dom->loadHTML( $primary_navigation );
+	$wp_block_navigation__container = $dom->getElementsByTagName('ul')->item( 0 );
+	$social_links_node = $dom->createDocumentFragment();
+	$social_links_node->appendXML( $social_links_block );
+	$wp_block_navigation__container->appendChild( $social_links_node );
+	$navigation_block = $dom->getElementsByTagName('nav')->item( 0 );
+	return $dom->saveXML( $navigation_block );
+}
+
+function blockbase_social_menu_render( $block_content, $block ) {
+	if ( blockbase_condition_to_render_social_menu( $block ) ) {
+		$social_links_block = get_social_menu_as_social_links_block();
+
+		return append_social_links_block_to_primary_navigation( $block_content, $social_links_block );
+	}
+
+	return $block_content;
+}
+
+/**
+ * Hijack the render of the primary menu to inject a social menu.
+ */
+add_filter( 'render_block', 'blockbase_social_menu_render', 10, 2 );

From 8b8fbdfe425fa63a5f3aa822061b73128f11a7c6 Mon Sep 17 00:00:00 2001
From: Ben Dwyer <ben@scruffian.com>
Date: Tue, 5 Oct 2021 12:41:01 +0100
Subject: [PATCH 05/10] suppress warnings for HTML5 elements

---
 blockbase/inc/social-navigation.php | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/blockbase/inc/social-navigation.php b/blockbase/inc/social-navigation.php
index ac5bd6ea32..a4be60a410 100644
--- a/blockbase/inc/social-navigation.php
+++ b/blockbase/inc/social-navigation.php
@@ -45,6 +45,8 @@ function get_social_menu_as_social_links_block() {
 
 function append_social_links_block_to_primary_navigation( $primary_navigation, $social_links_block ) {
 	$dom = new domDocument;
+	// Since the nav block uses HTML5 element names, we need to suppress the warnings it sends when we loadHTML with HTML5 elements.
+	libxml_use_internal_errors( true );
 	$dom->loadHTML( $primary_navigation );
 	$wp_block_navigation__container = $dom->getElementsByTagName('ul')->item( 0 );
 	$social_links_node = $dom->createDocumentFragment();

From 382025d974dc286b618ac80836d8433338ee3450 Mon Sep 17 00:00:00 2001
From: Ben Dwyer <ben@scruffian.com>
Date: Tue, 5 Oct 2021 13:06:54 +0100
Subject: [PATCH 06/10] only append social links to a navigation block if the
 block opts in

---
 blockbase/block-template-parts/header.html |  2 +-
 blockbase/inc/social-navigation.php        | 16 +++++++++++++---
 2 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/blockbase/block-template-parts/header.html b/blockbase/block-template-parts/header.html
index d58e04010d..1a35567b7a 100644
--- a/blockbase/block-template-parts/header.html
+++ b/blockbase/block-template-parts/header.html
@@ -3,6 +3,6 @@
 	<!-- wp:site-logo /-->
 	<!-- wp:site-title /-->
 	<!-- wp:site-tagline {"fontSize":"tiny"} /-->
-	<!-- wp:navigation {"itemsJustification":"right","isResponsive":true,"__unstableLocation":"primary"} /-->
+	<!-- wp:navigation {"itemsJustification":"right","isResponsive":true,"__unstableLocation":"primary","__unstableSocialLinks":"social"} /-->
 </div>
 <!-- /wp:group -->
diff --git a/blockbase/inc/social-navigation.php b/blockbase/inc/social-navigation.php
index a4be60a410..b29da176a5 100644
--- a/blockbase/inc/social-navigation.php
+++ b/blockbase/inc/social-navigation.php
@@ -23,12 +23,22 @@ function blockbase_condition_to_render_social_menu( $block ) {
 		return false;
 	}
 
+	// The block should have a social links attribute.
+	if ( empty( $block['attrs']['__unstableSocialLinks'] ) ) {
+		return false;
+	}
+
 	return true;
 }
 
-function get_social_menu_as_social_links_block() {
+function get_social_menu_as_social_links_block( $block ) {
+	if ( empty( $block['attrs']['__unstableSocialLinks'] ) ) {
+		return false;
+	}
+
+	$social_links_location = $block['attrs']['__unstableSocialLinks'];
 	$nav_menu_locations = get_nav_menu_locations();
-	$social_menu_id = $nav_menu_locations['social'];
+	$social_menu_id = $nav_menu_locations[ $social_links_location ];
 	$class_name = 'is-style-logos-only';
 	if( ! empty( $block['attrs']['itemsJustification'] ) ) {
 		$class_name .= ' items-justified-' . $block['attrs']['itemsJustification'];
@@ -58,7 +68,7 @@ function append_social_links_block_to_primary_navigation( $primary_navigation, $
 
 function blockbase_social_menu_render( $block_content, $block ) {
 	if ( blockbase_condition_to_render_social_menu( $block ) ) {
-		$social_links_block = get_social_menu_as_social_links_block();
+		$social_links_block = get_social_menu_as_social_links_block( $block );
 
 		return append_social_links_block_to_primary_navigation( $block_content, $social_links_block );
 	}

From 854f4b3b1671a7d68764f5cf201cc7b0bb2f9925 Mon Sep 17 00:00:00 2001
From: Ben Dwyer <ben@scruffian.com>
Date: Wed, 6 Oct 2021 14:02:39 +0100
Subject: [PATCH 07/10] Fix fatal

---
 blockbase/inc/social-navigation.php | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/blockbase/inc/social-navigation.php b/blockbase/inc/social-navigation.php
index b29da176a5..218f20a80b 100644
--- a/blockbase/inc/social-navigation.php
+++ b/blockbase/inc/social-navigation.php
@@ -2,7 +2,7 @@
 
 // We should only change the render of the navigtion block
 // to social links in the following conditions.
-function blockbase_condition_to_render_social_menu( $block ) {
+function blockbase_condition_to_render_social_menu( $block_content, $block ) {
 	// The block should be a navigation block.
 	if ( 'core/navigation' !== $block['blockName'] ) {
 		return false;
@@ -28,6 +28,10 @@ function blockbase_condition_to_render_social_menu( $block ) {
 		return false;
 	}
 
+	if ( empty( $block_content ) ) {
+		return false;
+	}
+
 	return true;
 }
 
@@ -67,7 +71,7 @@ function append_social_links_block_to_primary_navigation( $primary_navigation, $
 }
 
 function blockbase_social_menu_render( $block_content, $block ) {
-	if ( blockbase_condition_to_render_social_menu( $block ) ) {
+	if ( blockbase_condition_to_render_social_menu( $block_content, $block ) ) {
 		$social_links_block = get_social_menu_as_social_links_block( $block );
 
 		return append_social_links_block_to_primary_navigation( $block_content, $social_links_block );

From 4f6db5b2776e795fb346cfc676ae2444b956f245 Mon Sep 17 00:00:00 2001
From: Jason Crist <jcrist@pbking.com>
Date: Mon, 11 Oct 2021 12:26:24 -0400
Subject: [PATCH 08/10] Removed requirement to have social parent container be
 primary menu (or even have content)

---
 blockbase/inc/social-navigation.php | 25 +++++++------------------
 1 file changed, 7 insertions(+), 18 deletions(-)

diff --git a/blockbase/inc/social-navigation.php b/blockbase/inc/social-navigation.php
index 218f20a80b..d5d87a36f8 100644
--- a/blockbase/inc/social-navigation.php
+++ b/blockbase/inc/social-navigation.php
@@ -13,25 +13,11 @@ function blockbase_condition_to_render_social_menu( $block_content, $block ) {
 		return false;
 	}
 
-	// The block should have a loction defined.
-	if ( empty( $block['attrs']['__unstableLocation'] ) ) {
-		return false;
-	}
-
-	// The block's location should be 'primary'.
-	if ( $block['attrs']['__unstableLocation'] !== 'primary' ) {
-		return false;
-	}
-
 	// The block should have a social links attribute.
 	if ( empty( $block['attrs']['__unstableSocialLinks'] ) ) {
 		return false;
 	}
 
-	if ( empty( $block_content ) ) {
-		return false;
-	}
-
 	return true;
 }
 
@@ -57,11 +43,14 @@ function get_social_menu_as_social_links_block( $block ) {
 	return do_blocks( $social_links_content );
 }
 
-function append_social_links_block_to_primary_navigation( $primary_navigation, $social_links_block ) {
+function append_social_links_block( $parent_content, $social_links_block ) {
+	if ( empty( $parent_content ) ) {
+		return $social_links_block;
+	}
 	$dom = new domDocument;
 	// Since the nav block uses HTML5 element names, we need to suppress the warnings it sends when we loadHTML with HTML5 elements.
 	libxml_use_internal_errors( true );
-	$dom->loadHTML( $primary_navigation );
+	$dom->loadHTML( $parent_content );
 	$wp_block_navigation__container = $dom->getElementsByTagName('ul')->item( 0 );
 	$social_links_node = $dom->createDocumentFragment();
 	$social_links_node->appendXML( $social_links_block );
@@ -74,13 +63,13 @@ function blockbase_social_menu_render( $block_content, $block ) {
 	if ( blockbase_condition_to_render_social_menu( $block_content, $block ) ) {
 		$social_links_block = get_social_menu_as_social_links_block( $block );
 
-		return append_social_links_block_to_primary_navigation( $block_content, $social_links_block );
+		return append_social_links_block( $block_content, $social_links_block );
 	}
 
 	return $block_content;
 }
 
 /**
- * Hijack the render of the primary menu to inject a social menu.
+ * Hijack the render of the menu block to inject a social menu.
  */
 add_filter( 'render_block', 'blockbase_social_menu_render', 10, 2 );

From 30e1c0978543b70a8a294b2840d53a9dfa500b15 Mon Sep 17 00:00:00 2001
From: Ben Dwyer <ben@scruffian.com>
Date: Tue, 12 Oct 2021 13:06:17 +0100
Subject: [PATCH 09/10] Fix layout for social nav

---
 geologist/block-template-parts/header.html     |  2 +-
 .../block-template-parts/header.html           |  5 ++---
 quadrat/block-template-parts/header.html       |  2 +-
 seedlet-blocks/assets/theme.css                |  6 +++++-
 .../block-template-parts/header.html           |  3 +--
 seedlet-blocks/sass/blocks/_navigation.scss    |  8 ++++++--
 skatepark/assets/theme.css                     | 18 ++++++++++++------
 skatepark/block-template-parts/header.html     |  7 +++----
 skatepark/sass/templates/_header.scss          | 15 +++++++++++----
 videomaker/block-template-parts/header.html    |  2 +-
 10 files changed, 43 insertions(+), 25 deletions(-)

diff --git a/geologist/block-template-parts/header.html b/geologist/block-template-parts/header.html
index 5ba191f128..843594255c 100644
--- a/geologist/block-template-parts/header.html
+++ b/geologist/block-template-parts/header.html
@@ -3,6 +3,6 @@
 	<!-- wp:site-logo /-->
 	<!-- wp:site-title /-->
 	<!-- wp:site-tagline {"style":{"typography":{"fontSize":"var(--wp--custom--font-sizes--tiny)"}}} /-->
-	<!-- wp:navigation {"itemsJustification":"right","isResponsive":true,"__unstableLocation":"primary"} /-->
+	<!-- wp:navigation {"itemsJustification":"right","isResponsive":true,"__unstableLocation":"primary","__unstableSocialLinks":"social"} /-->
 </header>
 <!-- /wp:group -->
diff --git a/mayland-blocks/block-template-parts/header.html b/mayland-blocks/block-template-parts/header.html
index df620e50d1..9bb1a74446 100644
--- a/mayland-blocks/block-template-parts/header.html
+++ b/mayland-blocks/block-template-parts/header.html
@@ -2,8 +2,7 @@
 <div class="wp-block-group site-header" style="padding-bottom:32px">
 <!-- wp:site-logo /-->
 <!-- wp:site-title /-->
-<!-- wp:site-tagline {"fontSize":"tiny"} /-->
-<!-- wp:navigation {"orientation":"horizontal","textColor":"foreground-light","itemsJustification":"right","fontSize":"small","isResponsive":true,"__unstableLocation":"primary"} -->
-<!-- /wp:navigation -->
+<!-- wp:site-tagline {"style":{"typography":{"fontSize":"var(--wp--custom--font-sizes--tiny)"}}} /-->
+<!-- wp:navigation {"textColor":"foreground-light","fontSize":"small","itemsJustification":"right","isResponsive":true,"__unstableLocation":"primary","__unstableSocialLinks":"social"} /-->
 </div>
 <!-- /wp:group -->
diff --git a/quadrat/block-template-parts/header.html b/quadrat/block-template-parts/header.html
index 742b963f33..9a81946824 100644
--- a/quadrat/block-template-parts/header.html
+++ b/quadrat/block-template-parts/header.html
@@ -3,6 +3,6 @@
 	<!-- wp:site-logo /-->
 	<!-- wp:site-title /-->
 	<!-- wp:site-tagline {"style":{"typography":{"fontSize":"var(--wp--custom--font-sizes--tiny)"}}} /-->
-	<!-- wp:navigation {"itemsJustification":"right","isResponsive":true,"__unstableLocation":"primary"} /-->
+	<!-- wp:navigation {"itemsJustification":"right","isResponsive":true,"__unstableLocation":"primary","__unstableSocialLinks":"social"} /-->
 </header>
 <!-- /wp:group -->
diff --git a/seedlet-blocks/assets/theme.css b/seedlet-blocks/assets/theme.css
index a539f22504..2ad0171a52 100644
--- a/seedlet-blocks/assets/theme.css
+++ b/seedlet-blocks/assets/theme.css
@@ -170,7 +170,11 @@
 	line-height: 30px;
 }
 
-/* NOTE: This can be removed when the rendering of the Navigation block, rendered with a Classic data source (by way of __unstableLocation), 
+.wp-block-navigation__responsive-container:not(.has-modal-open) .wp-block-social-links {
+	flex-basis: 100%;
+}
+
+/* NOTE: This can be removed when the rendering of the Navigation block, rendered with a Classic data source (by way of __unstableLocation),
 is passed all of the block attributes on the block definition in the template. */
 .wp-block-navigation__container {
 	justify-content: center;
diff --git a/seedlet-blocks/block-template-parts/header.html b/seedlet-blocks/block-template-parts/header.html
index ca903a93c4..6e959f7f46 100644
--- a/seedlet-blocks/block-template-parts/header.html
+++ b/seedlet-blocks/block-template-parts/header.html
@@ -8,8 +8,7 @@
 
 <!-- wp:site-tagline {"textAlign":"center","fontSize":"small"} /-->
 
-<!-- wp:navigation {"itemsJustification":"center","isResponsive":true,"__unstableLocation":"primary"} -->
-<!-- /wp:navigation -->
+<!-- wp:navigation {"itemsJustification":"center","isResponsive":true,"__unstableLocation":"primary","__unstableSocialLinks":"social"} /-->
 
 <!-- wp:spacer {"height":60} -->
 <div style="height:60px" aria-hidden="true" class="wp-block-spacer"></div>
diff --git a/seedlet-blocks/sass/blocks/_navigation.scss b/seedlet-blocks/sass/blocks/_navigation.scss
index cb4f598de7..518cc004df 100644
--- a/seedlet-blocks/sass/blocks/_navigation.scss
+++ b/seedlet-blocks/sass/blocks/_navigation.scss
@@ -16,10 +16,14 @@
 			}
 		}
 	}
+
+	&:not(.has-modal-open) .wp-block-social-links {
+		flex-basis: 100%;
+	}
 }
 
-/* NOTE: This can be removed when the rendering of the Navigation block, rendered with a Classic data source (by way of __unstableLocation), 
+/* NOTE: This can be removed when the rendering of the Navigation block, rendered with a Classic data source (by way of __unstableLocation),
 is passed all of the block attributes on the block definition in the template. */
 .wp-block-navigation__container {
 	justify-content: center;
-}
\ No newline at end of file
+}
diff --git a/skatepark/assets/theme.css b/skatepark/assets/theme.css
index ee9112bc15..0e762b2403 100644
--- a/skatepark/assets/theme.css
+++ b/skatepark/assets/theme.css
@@ -524,16 +524,16 @@ header.wp-block-template-part > .wp-block-group > * > * {
 	}
 }
 
-header.wp-block-template-part > .wp-block-group .wp-block-social-links.is-style-logos-only {
-	margin-right: -2px;
-}
-
 @media (min-width: 600px) {
-	header.wp-block-template-part > .wp-block-group .wp-block-social-links.is-style-logos-only {
-		margin-top: calc( -1 * ( 8px + 0.25em ));
+	header.wp-block-template-part > .wp-block-group .wp-block-social-links {
+		flex-basis: 100%;
 	}
 }
 
+header.wp-block-template-part > .wp-block-group .wp-block-social-links.is-style-logos-only {
+	margin-right: -2px;
+}
+
 @media (max-width: 599px) {
 	header.wp-block-template-part > .wp-block-group .wp-block-social-links.is-style-logos-only {
 		margin-left: -0.25em;
@@ -556,6 +556,12 @@ header.wp-block-template-part .site-brand {
 	grid-template-columns: auto 1fr;
 }
 
+@media (min-width: 600px) {
+	header.wp-block-template-part .site-brand {
+		grid-template-rows: 35px auto;
+	}
+}
+
 @media (max-width: 599px) {
 	header.wp-block-template-part .site-brand {
 		grid-template-areas: "logo" "title" "tagline";
diff --git a/skatepark/block-template-parts/header.html b/skatepark/block-template-parts/header.html
index ce91e1ab9f..e4865a3793 100644
--- a/skatepark/block-template-parts/header.html
+++ b/skatepark/block-template-parts/header.html
@@ -1,4 +1,4 @@
-<!-- wp:group { "layout":{"type":"flex"}} -->
+<!-- wp:group {"layout":{"type":"flex"}} -->
 <div class="wp-block-group">
 <!-- wp:group {"className":"site-brand"} -->
 <div class="wp-block-group site-brand">
@@ -8,9 +8,8 @@
 <!-- /wp:group -->
 
 <!-- wp:group {"className":"nav-links"} -->
-<div class="wp-block-group nav-links"><!-- wp:navigation {"orientation":"horizontal","itemsJustification":"right","isResponsive":true,"__unstableLocation":"primary","style":{"typography":{"fontStyle":"normal","fontWeight":"900","textTransform":"uppercase"}},"fontSize":"small"} -->
-<!-- /wp:navigation -->
-
+<div class="wp-block-group nav-links">
+	<!-- wp:navigation {"orientation":"horizontal","itemsJustification":"right","isResponsive":true,"__unstableLocation":"primary","style":{"typography":{"fontStyle":"normal","fontWeight":"900","textTransform":"uppercase"}},"fontSize":"small","__unstableSocialLinks":"social"} /-->
 </div>
 <!-- /wp:group -->
 </div>
diff --git a/skatepark/sass/templates/_header.scss b/skatepark/sass/templates/_header.scss
index d2d61a8f0d..c1658ec7f3 100644
--- a/skatepark/sass/templates/_header.scss
+++ b/skatepark/sass/templates/_header.scss
@@ -3,7 +3,7 @@ header.wp-block-template-part {
 	margin: 0 auto;
 	width: 100%;
 	margin-top: calc( 0.5 * var(--wp--custom--gap--vertical) );
-	
+
 	> .wp-block-group {
 		gap: 0;
 		justify-content: space-between; // Apply a cluster (flex?) layout
@@ -30,11 +30,13 @@ header.wp-block-template-part {
 		}
 
 		.wp-block-social-links {
+			@include break-small(){
+				flex-basis: 100%;
+			}
+
 			&.is-style-logos-only {
 				margin-right: -2px; // Visually align social links to the right
-				@include break-small(){
-					margin-top: calc( -1 * ( 8px + 0.25em ) ); // Visually align social links to the tagline
-				}
+
 				@include break-small-only(){
 					margin-left: -0.25em;
 					margin-right: 0;
@@ -57,6 +59,11 @@ header.wp-block-template-part {
 			"logo title"
 			"logo tagline";
 		grid-template-columns: auto 1fr;
+
+		@include break-small(){
+			grid-template-rows: 35px auto;
+		}
+
 		@include break-small-only(){
 			grid-template-areas:
 				"logo"
diff --git a/videomaker/block-template-parts/header.html b/videomaker/block-template-parts/header.html
index 0ce759cfb9..aa3e42584f 100644
--- a/videomaker/block-template-parts/header.html
+++ b/videomaker/block-template-parts/header.html
@@ -3,6 +3,6 @@
 	<!-- wp:site-logo /-->
 	<!-- wp:site-title /-->
 	<!-- wp:site-tagline /-->
-	<!-- wp:navigation {"itemsJustification":"right","isResponsive":true,"__unstableLocation":"primary"} /-->
+	<!-- wp:navigation {"itemsJustification":"right","isResponsive":true,"__unstableLocation":"primary","__unstableSocialLinks":"social"} /-->
 </header>
 <!-- /wp:group -->

From 676738bd2b236f541485f07a27150aaf1305b7ab Mon Sep 17 00:00:00 2001
From: Ben Dwyer <ben@scruffian.com>
Date: Tue, 12 Oct 2021 14:19:45 +0100
Subject: [PATCH 10/10] Update the structure of the social links when appended
 to match the way that the navigation block works

---
 blockbase/assets/ponyfill.css              |  5 +++++
 blockbase/block-template-parts/header.html |  2 +-
 blockbase/inc/social-navigation.php        |  3 ++-
 blockbase/sass/base/_header.scss           |  8 +++++++-
 skatepark/assets/theme.css                 | 18 ++----------------
 skatepark/sass/templates/_header.scss      | 11 +----------
 6 files changed, 18 insertions(+), 29 deletions(-)

diff --git a/blockbase/assets/ponyfill.css b/blockbase/assets/ponyfill.css
index d245153a14..a48aeb5394 100644
--- a/blockbase/assets/ponyfill.css
+++ b/blockbase/assets/ponyfill.css
@@ -194,6 +194,11 @@ pre {
 	}
 }
 
+.wp-site-blocks .site-header .wp-block-navigation__responsive-container-content {
+	display: flex;
+	gap: var(--wp--style--block-gap, 2em);
+}
+
 :root {
 	--wpadmin-bar--height: 46px;
 }
diff --git a/blockbase/block-template-parts/header.html b/blockbase/block-template-parts/header.html
index 1a35567b7a..552ce2ff4f 100644
--- a/blockbase/block-template-parts/header.html
+++ b/blockbase/block-template-parts/header.html
@@ -2,7 +2,7 @@
 <div class="wp-block-group site-header" style="padding-bottom:80px">
 	<!-- wp:site-logo /-->
 	<!-- wp:site-title /-->
-	<!-- wp:site-tagline {"fontSize":"tiny"} /-->
+	<!-- wp:site-tagline {"style":{"typography":{"fontSize":"var(--wp--custom--font-sizes--tiny)"}}} /-->
 	<!-- wp:navigation {"itemsJustification":"right","isResponsive":true,"__unstableLocation":"primary","__unstableSocialLinks":"social"} /-->
 </div>
 <!-- /wp:group -->
diff --git a/blockbase/inc/social-navigation.php b/blockbase/inc/social-navigation.php
index d5d87a36f8..0cf6ed198e 100644
--- a/blockbase/inc/social-navigation.php
+++ b/blockbase/inc/social-navigation.php
@@ -48,10 +48,11 @@ function append_social_links_block( $parent_content, $social_links_block ) {
 		return $social_links_block;
 	}
 	$dom = new domDocument;
+	$domXPath = new DomXPath( $dom );
 	// Since the nav block uses HTML5 element names, we need to suppress the warnings it sends when we loadHTML with HTML5 elements.
 	libxml_use_internal_errors( true );
 	$dom->loadHTML( $parent_content );
-	$wp_block_navigation__container = $dom->getElementsByTagName('ul')->item( 0 );
+	$wp_block_navigation__container = $dom->getElementsByTagName('ul')->item( 0 )->parentNode;
 	$social_links_node = $dom->createDocumentFragment();
 	$social_links_node->appendXML( $social_links_block );
 	$wp_block_navigation__container->appendChild( $social_links_node );
diff --git a/blockbase/sass/base/_header.scss b/blockbase/sass/base/_header.scss
index e9bdd5eae9..e4bd7b8122 100644
--- a/blockbase/sass/base/_header.scss
+++ b/blockbase/sass/base/_header.scss
@@ -35,4 +35,10 @@
 			order: 10;
 		}
 	}
-}
\ No newline at end of file
+
+	.wp-block-navigation__responsive-container-content {
+		// Needed until https://github.com/WordPress/gutenberg/issues/35549 is fixed.
+		display: flex;
+		gap: var( --wp--style--block-gap, 2em );
+	}
+}
diff --git a/skatepark/assets/theme.css b/skatepark/assets/theme.css
index 0e762b2403..2151b4732e 100644
--- a/skatepark/assets/theme.css
+++ b/skatepark/assets/theme.css
@@ -524,21 +524,8 @@ header.wp-block-template-part > .wp-block-group > * > * {
 	}
 }
 
-@media (min-width: 600px) {
-	header.wp-block-template-part > .wp-block-group .wp-block-social-links {
-		flex-basis: 100%;
-	}
-}
-
-header.wp-block-template-part > .wp-block-group .wp-block-social-links.is-style-logos-only {
-	margin-right: -2px;
-}
-
-@media (max-width: 599px) {
-	header.wp-block-template-part > .wp-block-group .wp-block-social-links.is-style-logos-only {
-		margin-left: -0.25em;
-		margin-right: 0;
-	}
+header.wp-block-template-part > .wp-block-group .wp-block-social-links {
+	margin: 0;
 }
 
 header.wp-block-template-part > .wp-block-group .wp-block-social-links.is-style-logos-only > .wp-social-link {
@@ -616,7 +603,6 @@ header.wp-block-template-part .site-brand .wp-block-site-tagline {
 	}
 	.nav-links .wp-block-social-links {
 		justify-content: flex-start;
-		grid-area: social;
 	}
 }
 
diff --git a/skatepark/sass/templates/_header.scss b/skatepark/sass/templates/_header.scss
index c1658ec7f3..c2b74aa28e 100644
--- a/skatepark/sass/templates/_header.scss
+++ b/skatepark/sass/templates/_header.scss
@@ -30,17 +30,9 @@ header.wp-block-template-part {
 		}
 
 		.wp-block-social-links {
-			@include break-small(){
-				flex-basis: 100%;
-			}
+			margin: 0;
 
 			&.is-style-logos-only {
-				margin-right: -2px; // Visually align social links to the right
-
-				@include break-small-only(){
-					margin-left: -0.25em;
-					margin-right: 0;
-				}
 				> .wp-social-link {
 					padding: 0; // Needed to override Gutenberg default padding on this block style variation
 
@@ -108,7 +100,6 @@ header.wp-block-template-part {
 		}
 		.wp-block-social-links {
 			justify-content: flex-start;
-			grid-area: social;
 		}
 	}
 }