Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seedlet: Add theme support for custom spacing controls #2297

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Seedlet: Add theme support for custom spacing controls #2297

merged 1 commit into from
Jul 30, 2020

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented Jul 27, 2020

Closes #2280. Seems to work just fine in the front end too.

cover-padding

@kjellr kjellr added this to the Seedlet 1.1 Release milestone Jul 27, 2020
@kjellr kjellr requested a review from jffng July 27, 2020 14:32
@kjellr kjellr self-assigned this Jul 27, 2020
jffng
jffng reviewed Jul 28, 2020
View reviewed changes
Copy link
Contributor

@jffng jffng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm this isn't working for me, but seems like a Gutenberg bug (note the "NULL" value in the padding input field):

Screen Shot 2020-07-28 at 9 14 17 AM

I'm running the plugin version 8.6.0.

@kjellr
Copy link
Contributor Author

kjellr commented Jul 28, 2020

I saw that too, but once I typed in a value (e.g. 100px), it started working. If you're seeing that too, would you mind filing an issue for that in the GB repo?

@jffng
Copy link
Contributor

jffng commented Jul 28, 2020

WordPress/gutenberg#24245

@kjellr
Copy link
Contributor Author

kjellr commented Jul 29, 2020

Cool. Since that's a GB problem, I think this is good to go?

@jffng jffng merged commit 91b0354 into master Jul 30, 2020
@jffng jffng deleted the seedlet/add/custom-spacing-support branch July 30, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jffng jffng jffng left review comments

Assignees

@kjellr kjellr

Labels
[Theme] Seedlet Blocks [Theme] Seedlet [Type] Enhancement New feature or request
Projects
None yet
Milestone
Seedlet 1.1 Release
Development

Successfully merging this pull request may close these issues.

Seedlet Blocks: Add support for custom spacing controls for cover block
2 participants
@kjellr @jffng