Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Archeo] Small screen fixes #5631

Closed
4 tasks done
kjellr opened this issue Mar 7, 2022 · 2 comments · Fixed by #5731
Closed
4 tasks done

[Archeo] Small screen fixes #5631

kjellr opened this issue Mar 7, 2022 · 2 comments · Fixed by #5731
Assignees
@mikachan
Labels
[Theme] Archeo Automatically generated label for Archeo. [Type] Bug Something isn't working
Milestone
Archeo

Comments

@kjellr
Copy link
Contributor

kjellr commented Mar 7, 2022 •
edited by mikachan
Loading

Archeo has a few areas of its mobile templates that need adjustment:

The two areas indicated in pink should use the equivalent of 48px of padding.

Screen Shot 2022-03-07 at 3 32 36 PM

The spacing above each author name should be moved below it, so that the authors appear associated with the correct post titles on small screens:

Before After
Screen Shot 2022-03-07 at 3 38 27 PM Screen Shot 2022-03-07 at 3 38 19 PM

The spacing and alignment of this footer menu looks like a bug. Can this be left aligned? Can we remove the vertical blockGap?

Screen Shot 2022-03-07 at 3 39 57 PM

Before After
Screen Shot 2022-03-07 at 3 42 09 PM Screen Shot 2022-03-07 at 3 44 59 PM
@kjellr kjellr added [Type] Bug Something isn't working [Theme] Archeo Automatically generated label for Archeo. labels Mar 7, 2022
@kjellr kjellr added this to the Archeo milestone Mar 7, 2022
This was referenced Mar 8, 2022
Merged
Merged
Merged
Merged
@kjellr
Copy link
Contributor Author

kjellr commented Mar 22, 2022

I'm re-opening this one because that second one appears to be broken again:

Current Recommended
Screen Shot 2022-03-22 at 2 14 46 PM Screen Shot 2022-03-22 at 2 12 43 PM

@kjellr kjellr reopened this Mar 22, 2022
@mikachan mikachan self-assigned this Mar 23, 2022
@mikachan mikachan mentioned this issue Mar 23, 2022
Merged
@mikachan
Copy link
Member

Ah good spot, looks like it's been accidentally overwritten. I've brought that change back in here: #5731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikachan mikachan

Labels
[Theme] Archeo Automatically generated label for Archeo. [Type] Bug Something isn't working
Projects
None yet
Milestone
Archeo
Development

Successfully merging a pull request may close this issue.

Archeo: Reintroduce spacing fix Automattic/themes
2 participants
@kjellr @mikachan