Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archeo: Submit to dotorg checklist #5595

Closed
5 tasks done
MaggieCabrera opened this issue Feb 25, 2022 · 8 comments
Closed
5 tasks done

Archeo: Submit to dotorg checklist #5595

MaggieCabrera opened this issue Feb 25, 2022 · 8 comments
Labels
[Theme] Archeo Automatically generated label for Archeo.
Milestone

Comments

@MaggieCabrera
Copy link
Contributor

MaggieCabrera commented Feb 25, 2022

The only warnings for Archeo from the theme check plugin are:

WARNING: screenshot.jpg is 726.1 KB in size. Large file sizes have a negative impact on website performance and loading time. Compress images before using them.
WARNING: assets/images/chahk.png is 1.4 MB in size. Large file sizes have a negative impact on website performance and loading time. Compress images before using them.
@MaggieCabrera MaggieCabrera added the [Theme] Archeo Automatically generated label for Archeo. label Feb 25, 2022
@MaggieCabrera MaggieCabrera added this to the Archeo milestone Feb 25, 2022
@MaggieCabrera MaggieCabrera changed the title Archeo: Image sizes Archeo: Submit to dotorg checklist Feb 25, 2022
@kjellr
Copy link
Contributor

kjellr commented Mar 1, 2022

WARNING: screenshot.jpg is 726.1 KB in size. Large file sizes have a negative impact on website performance and loading time. Compress images before using them.
WARNING: assets/images/chahk.png is 1.4 MB in size. Large file sizes have a negative impact on website performance and loading time. Compress images before using them.

The top warning should be addressed in #5598. Unfortunately, chalk.png is about as small as it can get while retaining its usage at that large size. So we'll need to just ignore that second warning for now.

@MaggieCabrera
Copy link
Contributor Author

I want to remember that we had trouble in the past when we had too many images or too big ones on dotcom. Maybe we could make the background of chahk.png be the same color as the background of the site and make it a jpg?

@kjellr
Copy link
Contributor

kjellr commented Mar 4, 2022

I considered that (as well as using PNG-8 with a background-color-hinted border), but if folks change the background of the site it looks very poor immediately. That'll be frustrating for folks, and will also be weird if/when we implement alternate Styles. In any case, I'll take one more pass at exporting it next week just in case I missed an option last time around.

@kjellr
Copy link
Contributor

kjellr commented Mar 7, 2022

Update: I got a little closer towards reducing the file size by refining the cutout edges. I'm going to continue working on it tomorrow. 👍

@MaggieCabrera
Copy link
Contributor Author

MaggieCabrera commented Mar 8, 2022

Awesome @kjellr ! Just a heads up because I'm building the headstart for skatepark and I encountered this. The limit for theme images on dotcom:

[ ] Please Fix: https://skateparkdemo.files.wordpress.com/2021/09/13900064573_0b24c944f5_k.jpg is too large 700 kb (greater than 350 kb). Resize the image.

@kjellr
Copy link
Contributor

kjellr commented Mar 8, 2022

I've pushed #5635 to update this one. I don't think we will need to actually adhere to the 350kb limit for the Chahk image on WP.com because it is in the template itself — it won't need to be pulled in via headstart.

@MaggieCabrera
Copy link
Contributor Author

I've pushed #5635 to update this one. I don't think we will need to actually adhere to the 350kb limit for the Chahk image on WP.com because it is in the template itself — it won't need to be pulled in via headstart.

Very true!

@mikachan
Copy link
Member

Archeo is now available here! https://wordpress.org/themes/archeo/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Theme] Archeo Automatically generated label for Archeo.
Projects
None yet
Development

No branches or pull requests

3 participants