Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seedlet: Block Patterns show placeholders #2474

Closed
ianstewart opened this issue Sep 17, 2020 · 2 comments
Closed

Seedlet: Block Patterns show placeholders #2474

ianstewart opened this issue Sep 17, 2020 · 2 comments
Assignees
Labels

Comments

@ianstewart
Copy link
Contributor

It looks like the Seedlet Blocks Patterns previews are showing placeholders. cc @iamtakashi who noticed it.

image

@kjellr
Copy link
Contributor

kjellr commented Sep 24, 2020

The "correct" way to include images here would be to bundle the images in the theme, and then use them here by default, but that's not possible until a solution to WordPress/gutenberg#21932 is merged.

In the near term, the only other reasonable solution would be hotlinking to the image elsewhere. This is what we do for block pattern on WP.com, but it does seem a little weird to do so for self-hosted users.

@kjellr kjellr added [Theme] Seedlet [Type] Enhancement New feature or request labels Sep 24, 2020
@kjellr
Copy link
Contributor

kjellr commented Sep 24, 2020

Nevermind, @MaggieCabrera pointed out that since patterns are declared in PHP, it works fine to use get_template_directory_uri(). 😄

Bundling these images and linking to them that way seems like the most reasonable solution for now, and would make a good PR. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants